From 6cab792d78b317f466db82e354e45fd4cc9bb96e Mon Sep 17 00:00:00 2001 From: Vu Cong Tuan Date: Sun, 4 Jun 2017 11:55:54 +0700 Subject: [PATCH] Fix html_last_updated_fmt for Python3 html_last_updated_fmt option is interpreted as a byte string in python3, causing Sphinx build to break. This patch makes it utf-8 string. Changing Popen to check_output to make it consistent with keystone [1] [1] https://review.openstack.org/#/c/457142/ Change-Id: I126579da6cbdacfdbaed80ef968e43e0829e24e1 Closes-Bug:#1693670 --- doc/source/conf.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/source/conf.py b/doc/source/conf.py index 5b6c736..66f4f7d 100644 --- a/doc/source/conf.py +++ b/doc/source/conf.py @@ -154,8 +154,7 @@ modindex_common_prefix = ['keystoneauth1.'] git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'", "--date=local", "-n1"] try: - html_last_updated_fmt = subprocess.Popen( - git_cmd, stdout=subprocess.PIPE).communicate()[0] + html_last_updated_fmt = subprocess.check_output(git_cmd).decode('utf-8') except: warnings.warn('Cannot get last updated time from git repository. ' 'Not setting "html_last_updated_fmt".')