openstack/deb-python-keystoneauth1
Code Issues Proposed changes

Change hacking check to verify all oslo imports

Browse Source 
The hacking check was verifying that specific oslo imports
weren't using the oslo-namespaced package. Since all the oslo
libraries used by keystoneclient are now changed to use the
new package name the hacking check can be simplified.

bp drop-namespace-packages

Change-Id: I6466e857c6eda0add6918e9fb14dc9296ed98600
This commit is contained in:
Brant Knudson
2015-01-31 08:06:22 -06:00
parent d1064da9fe
commit 8a8b152566
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
keystoneclient/hacking/checks.py
View File

@@ -24,9 +24,7 @@ import re
def check_oslo_namespace_imports(logical_line, blank_before, filename): def check_oslo_namespace_imports(logical_line, blank_before, filename):
oslo_namespace_imports = re.compile( oslo_namespace_imports = re.compile(
r"(((from)|(import))\s+oslo\." r"(((from)|(import))\s+oslo\.)|(from\s+oslo\s+import\s+)")
"((config)|(serialization)|(utils)|(i18n)))|"
"(from\s+oslo\s+import\s+((config)|(serialization)|(utils)|(i18n)))")
if re.match(oslo_namespace_imports, logical_line): if re.match(oslo_namespace_imports, logical_line):
msg = ("K333: '%s' must be used instead of '%s'.") % ( msg = ("K333: '%s' must be used instead of '%s'.") % (