openstack/deb-python-keystoneclient
Code Issues Proposed changes

Fix a comment error in cms.py

Browse Source 
The comment of function is_asn1_token says "Max length of the
content using 2 octets is 7FFF or 32767", which should be 3FFF or
16383. Using Base64 string "MII" as the pki asn1 prefix, whose
binary form is 0x3082+0b00, the two octets for content length will
start with 0b00, so the max length is 0b0011+0xFFF(0x3FFF).

Change-Id: I6c3cedc0243a60328e0e7bd45957616ad272f524
This commit is contained in:
zhiyuan_cai
2015-01-04 15:57:08 +08:00
parent 53a82232ff
commit 727f5e77e2
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
keystoneclient/common/cms.py
View File

@@ -291,7 +291,7 @@ def is_asn1_token(token):
Checking for just M is insufficient
But we will only check for MII:
Max length of the content using 2 octets is 7FFF or 32767.
Max length of the content using 2 octets is 3FFF or 16383.
It's not practical to support a token of this length or greater in http
therefore, we will check for MII only and ignore the case of larger tokens