fea8bb64ba
This patch builds a small hierarchy of event objects that represent the payload for callback notification events. The overall goal of this work is to begin moving away from the existing unstructured **kwargs passed today and standardize on a common set of event payload objects; the beginning of such contained herein. A PoC/dummy patch for neutron is provided in [1] that exemplifies consumption of the new API by: - Removes neutron.callbacks and moves all uses to neutron_lib.callbacks. - Neutron uses of callbacks for BEFORE_RESPONSE events now use neutron-lib. - Neutron uses of callbacks for ROUTER and PROCESS resource events now use neutron-lib. - Neutron UTs updated to pass with this patch. For existing discussion on this approach please see [2][3]. Co-Authored-By: Armando Migliaccio <armamig@gmail.com> [1] https://review.openstack.org/400404/ [2] https://review.openstack.org/#/c/345718 [3] https://review.openstack.org/#/c/342304 Change-Id: If76457b1f0d5d3479e394d0dba3b22a90928f0f2
46 lines
1.5 KiB
Python
46 lines
1.5 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
|
|
from oslotest import base
|
|
|
|
from neutron_lib.callbacks import registry
|
|
from neutron_lib import fixture
|
|
from neutron_lib.plugins import directory
|
|
|
|
|
|
class PluginDirectoryFixtureTestCase(base.BaseTestCase):
|
|
|
|
def setUp(self):
|
|
super(PluginDirectoryFixtureTestCase, self).setUp()
|
|
self.directory = mock.Mock()
|
|
self.useFixture(fixture.PluginDirectoryFixture(
|
|
plugin_directory=self.directory))
|
|
|
|
def test_fixture(self):
|
|
directory.add_plugin('foo', 'foo')
|
|
self.assertTrue(self.directory.add_plugin.called)
|
|
|
|
|
|
class CallbackRegistryFixtureTestCase(base.BaseTestCase):
|
|
|
|
def setUp(self):
|
|
super(CallbackRegistryFixtureTestCase, self).setUp()
|
|
self.manager = mock.Mock()
|
|
self.useFixture(fixture.CallbackRegistryFixture(
|
|
callback_manager=self.manager))
|
|
|
|
def test_fixture(self):
|
|
registry.notify('a', 'b', self)
|
|
self.assertTrue(self.manager.notify.called)
|