openstack/deb-python-neutronclient
Code Issues Proposed changes

Update hacking to 0.10

Browse Source 
Release notes:
http://git.openstack.org/cgit/openstack-dev/hacking/tag/?id=0.10.0

* Fix W292 (no newline at end of file)
* Fix H238 (old style class declaration, use new style)
* Skip H105 (Don't use author tags) temporarily.
* Remove H307 from ignore list since it is removed from Hacking rule.
* Remove H302 (import only modules) since there is no violation now.

Change-Id: Ic5967652819c9c322de327d504882a0e3029d462
This commit is contained in:
Akihiro Motoki
2015-03-23 15:15:16 +09:00
parent 9b5d39789f
commit e2ca29134c
5 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
neutronclient/neutron/v2_0/agentscheduler.py
View File

@@ -327,4 +327,4 @@ class GetLbaasAgentHostingLoadBalancer(neutronV20.ListCommand):
agent = neutron_client.get_lbaas_agent_hosting_loadbalancer( agent = neutron_client.get_lbaas_agent_hosting_loadbalancer(
**search_opts) **search_opts)
data = {'agents': [agent['agent']]} data = {'agents': [agent['agent']]}
return data return data

2
neutronclient/tests/unit/test_cli20.py
View File

@@ -50,7 +50,7 @@ def capture_std_streams():
sys.stdout, sys.stderr = stdout, stderr sys.stdout, sys.stderr = stdout, stderr
class FakeStdout: class FakeStdout(object):
def __init__(self): def __init__(self):
self.content = [] self.content = []

2
neutronclient/tests/unit/test_validators.py
View File

@@ -19,7 +19,7 @@ from neutronclient.common import exceptions
from neutronclient.common import validators from neutronclient.common import validators
class FakeParsedArgs(): class FakeParsedArgs(object):
pass pass

2
test-requirements.txt
View File

@@ -1,7 +1,7 @@
# The order of packages is significant, because pip processes them in the order # The order of packages is significant, because pip processes them in the order
# of appearance. Changing the order has an impact on the overall integration # of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
hacking>=0.9.2,<0.10 hacking>=0.10.0,<0.11
cliff-tablib>=1.0 cliff-tablib>=1.0
coverage>=3.6 coverage>=3.6

5
tox.ini
View File

@@ -38,12 +38,11 @@ downloadcache = ~/cache/pip
[flake8] [flake8]
# E125 continuation line does not distinguish itself from next logical line # E125 continuation line does not distinguish itself from next logical line
# H302 import only modules
# #
# TODO Fix the following rules from hacking 0.9.x # TODO Fix the following rules from hacking 0.9.x
# E265 block comment should start with '# ' # E265 block comment should start with '# '
# H105 Don't use author tags
# H405 multi line docstring summary not separated with an empty line # H405 multi line docstring summary not separated with an empty line
# H307 like imports should be grouped together ignore = E125,E265,H105,H405
ignore = E125,E265,H302,H307,H405
show-source = true show-source = true
exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,tools exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,tools