openstack/deb-python-oauth2client
Code Issues Proposed changes

The 'method' parameter for httlib2 is not positional.

Browse Source 
Reviewed in https://codereview.appspot.com/8522043/.
This commit is contained in:
Joe Gregorio
2013-04-30 16:29:33 -04:00
parent 9f1274c1a0
commit 28f34e7c12
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apiclient/http.py
View File

@@ -738,7 +738,7 @@ class HttpRequest(object):
start_headers['X-Upload-Content-Length'] = size start_headers['X-Upload-Content-Length'] = size
start_headers['content-length'] = str(self.body_size) start_headers['content-length'] = str(self.body_size)
resp, content = http.request(self.uri, self.method, resp, content = http.request(self.uri, method=self.method,
body=self.body, body=self.body,
headers=start_headers) headers=start_headers)
if resp.status == 200 and 'location' in resp: if resp.status == 200 and 'location' in resp:
@@ -793,7 +793,7 @@ class HttpRequest(object):
'Content-Length': str(chunk_end - self.resumable_progress + 1) 'Content-Length': str(chunk_end - self.resumable_progress + 1)
} }
try: try:
resp, content = http.request(self.resumable_uri, 'PUT', resp, content = http.request(self.resumable_uri, method='PUT',
body=data, body=data,
headers=headers) headers=headers)
except: except:
@@ -1162,7 +1162,7 @@ class BatchHttpRequest(object):
headers['content-type'] = ('multipart/mixed; ' headers['content-type'] = ('multipart/mixed; '
'boundary="%s"') % message.get_boundary() 'boundary="%s"') % message.get_boundary()
resp, content = http.request(self._batch_uri, 'POST', body=body, resp, content = http.request(self._batch_uri, method='POST', body=body,
headers=headers) headers=headers)
if resp.status >= 300: if resp.status >= 300: