openstack/deb-python-oauth2client
Code Issues Proposed changes

Added patch to fix a bug introduced by V1 of the Buzz discovery document because it uses an invalid base URL.

Browse Source
This commit is contained in:
ade@google.com
2010-09-29 16:42:15 +01:00
parent d6d6f2f62a
commit 7ebb2ca822
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apiclient/discovery.py
View File

@@ -236,8 +236,14 @@ def createResource(http, baseUrl, model, resourceName, developerKey,
headers, params, query, body = self._model.request(headers,
actual_path_params, actual_query_params, body_value)
# TODO(ade) This exists to fix a bug in V1 of the Buzz discovery document.
# Base URLs should not contain any path elements. If they do then urlparse.urljoin will strip them out
# This results in an incorrect URL which returns a 404
url_result = urlparse.urlsplit(self._baseUrl)
new_base_url = url_result.scheme + '://' + url_result.netloc
expanded_url = uritemplate.expand(pathUrl, params)
url = urlparse.urljoin(self._baseUrl, expanded_url + query)
url = urlparse.urljoin(new_base_url, url_result.path + expanded_url + query)
logging.info('URL being requested: %s' % url)
return HttpRequest(self._http, url, method=httpMethod, body=body,