openstack/deb-python-oauth2client
Code Issues Proposed changes

Fix close/unlink order for file locking.

Browse Source 
Reviewed in https://codereview.appspot.com/7313056/.
This commit is contained in:
Joe Gregorio
2013-02-07 22:32:55 -05:00
parent cdc350fbb1
commit c1fb7100e2
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
oauth2client/locked_file.py
View File

@@ -142,8 +142,8 @@ class _PosixOpener(_Opener):
"""Unlock a file by removing the .lock file, and close the handle.""" """Unlock a file by removing the .lock file, and close the handle."""
if self._locked: if self._locked:
lock_filename = self._posix_lockfile(self._filename) lock_filename = self._posix_lockfile(self._filename)
os.unlink(lock_filename)
os.close(self._lock_fd) os.close(self._lock_fd)
os.unlink(lock_filename)
self._locked = False self._locked = False
self._lock_fd = None self._lock_fd = None
if self._fh: if self._fh: