From 466a2be3274d72d000e02561d1613fc6377aa0d3 Mon Sep 17 00:00:00 2001 From: Gerrit Code Review Date: Thu, 22 Sep 2016 07:20:00 +0000 Subject: [PATCH] Update notes for submitted changes * Updated from global requirements * Fix "volume unset" command pass normally when nothing specified * Use correct router add/remove interface methods * Refactor volume unit test with FakeVolume class in volume v1 * replace metavar "volume-id" with "volume" to avoid ambiguity * Remove unnecessary setUp --- 27/4e400f5a033da073a8a790eb4895fe7faced86 | 8 ++++++++ 47/b782687f4c23d03e872fb2b2b69b57ba3f9aec | 10 ++++++++++ 4a/8b802d6b1b4de4979260234b0fda4b18a01699 | 9 +++++++++ 6f/0462732a999f43ca0a602e1f323c833debaa5c | 9 +++++++++ b3/0a7b795f346e7ccc5575602550ca430bfb71a0 | 9 +++++++++ bb/a5c9047f81439a18e4e8be434f51abab83a24a | 9 +++++++++ 6 files changed, 54 insertions(+) create mode 100644 27/4e400f5a033da073a8a790eb4895fe7faced86 create mode 100644 47/b782687f4c23d03e872fb2b2b69b57ba3f9aec create mode 100644 4a/8b802d6b1b4de4979260234b0fda4b18a01699 create mode 100644 6f/0462732a999f43ca0a602e1f323c833debaa5c create mode 100644 b3/0a7b795f346e7ccc5575602550ca430bfb71a0 create mode 100644 bb/a5c9047f81439a18e4e8be434f51abab83a24a diff --git a/27/4e400f5a033da073a8a790eb4895fe7faced86 b/27/4e400f5a033da073a8a790eb4895fe7faced86 new file mode 100644 index 00000000..219e76ce --- /dev/null +++ b/27/4e400f5a033da073a8a790eb4895fe7faced86 @@ -0,0 +1,8 @@ +Code-Review+2: Richard Theis +Workflow+1: Richard Theis +Verified+2: Jenkins +Submitted-by: Jenkins +Submitted-at: Wed, 21 Sep 2016 14:36:56 +0000 +Reviewed-on: https://review.openstack.org/373716 +Project: openstack/deb-python-openstackclient +Branch: refs/heads/master diff --git a/47/b782687f4c23d03e872fb2b2b69b57ba3f9aec b/47/b782687f4c23d03e872fb2b2b69b57ba3f9aec new file mode 100644 index 00000000..dcbd6ce9 --- /dev/null +++ b/47/b782687f4c23d03e872fb2b2b69b57ba3f9aec @@ -0,0 +1,10 @@ +Code-Review+2: Tang Chen +Code-Review+1: Huanxuan Ao +Code-Review+2: Richard Theis +Workflow+1: Richard Theis +Verified+2: Jenkins +Submitted-by: Jenkins +Submitted-at: Wed, 21 Sep 2016 15:49:22 +0000 +Reviewed-on: https://review.openstack.org/373823 +Project: openstack/deb-python-openstackclient +Branch: refs/heads/master diff --git a/4a/8b802d6b1b4de4979260234b0fda4b18a01699 b/4a/8b802d6b1b4de4979260234b0fda4b18a01699 new file mode 100644 index 00000000..88d1a746 --- /dev/null +++ b/4a/8b802d6b1b4de4979260234b0fda4b18a01699 @@ -0,0 +1,9 @@ +Code-Review+2: Steve Martinelli +Code-Review+2: Tang Chen +Workflow+1: Tang Chen +Verified+2: Jenkins +Submitted-by: Jenkins +Submitted-at: Thu, 22 Sep 2016 02:33:59 +0000 +Reviewed-on: https://review.openstack.org/373732 +Project: openstack/deb-python-openstackclient +Branch: refs/heads/master diff --git a/6f/0462732a999f43ca0a602e1f323c833debaa5c b/6f/0462732a999f43ca0a602e1f323c833debaa5c new file mode 100644 index 00000000..02aefc49 --- /dev/null +++ b/6f/0462732a999f43ca0a602e1f323c833debaa5c @@ -0,0 +1,9 @@ +Code-Review+2: Steve Martinelli +Code-Review+2: Tang Chen +Workflow+1: Tang Chen +Verified+2: Jenkins +Submitted-by: Jenkins +Submitted-at: Wed, 21 Sep 2016 04:30:29 +0000 +Reviewed-on: https://review.openstack.org/373597 +Project: openstack/deb-python-openstackclient +Branch: refs/heads/master diff --git a/b3/0a7b795f346e7ccc5575602550ca430bfb71a0 b/b3/0a7b795f346e7ccc5575602550ca430bfb71a0 new file mode 100644 index 00000000..f1fe48b2 --- /dev/null +++ b/b3/0a7b795f346e7ccc5575602550ca430bfb71a0 @@ -0,0 +1,9 @@ +Code-Review+2: Steve Martinelli +Code-Review+2: Tang Chen +Workflow+1: Tang Chen +Verified+2: Jenkins +Submitted-by: Jenkins +Submitted-at: Wed, 21 Sep 2016 07:48:45 +0000 +Reviewed-on: https://review.openstack.org/373641 +Project: openstack/deb-python-openstackclient +Branch: refs/heads/master diff --git a/bb/a5c9047f81439a18e4e8be434f51abab83a24a b/bb/a5c9047f81439a18e4e8be434f51abab83a24a new file mode 100644 index 00000000..e6146baa --- /dev/null +++ b/bb/a5c9047f81439a18e4e8be434f51abab83a24a @@ -0,0 +1,9 @@ +Code-Review+2: Steve Martinelli +Code-Review+2: Dean Troyer +Workflow+1: Dean Troyer +Verified+2: Jenkins +Submitted-by: Jenkins +Submitted-at: Thu, 22 Sep 2016 02:35:13 +0000 +Reviewed-on: https://review.openstack.org/373836 +Project: openstack/deb-python-openstackclient +Branch: refs/heads/master