 258c1102cc
			
		
	
	258c1102cc
	
	
	
		
			
			Previously each command logs take_action parameters explicitly by using @utils.log_method decorator or log.debug(). Some commands have no logging. This commit calls a logger in the base class and drops all logging definition from individual commands. Closes-Bug: #1532294 Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
		
			
				
	
	
		
			184 lines
		
	
	
		
			5.7 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			184 lines
		
	
	
		
			5.7 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
| #
 | |
| #   Licensed under the Apache License, Version 2.0 (the "License"); you may
 | |
| #   not use this file except in compliance with the License. You may obtain
 | |
| #   a copy of the License at
 | |
| #
 | |
| #        http://www.apache.org/licenses/LICENSE-2.0
 | |
| #
 | |
| #   Unless required by applicable law or agreed to in writing, software
 | |
| #   distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 | |
| #   WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 | |
| #   License for the specific language governing permissions and limitations
 | |
| #   under the License.
 | |
| #
 | |
| 
 | |
| """Volume v2 Backup action implementations"""
 | |
| 
 | |
| import copy
 | |
| 
 | |
| import six
 | |
| 
 | |
| from openstackclient.common import command
 | |
| from openstackclient.common import utils
 | |
| 
 | |
| 
 | |
| class CreateBackup(command.ShowOne):
 | |
|     """Create new backup"""
 | |
| 
 | |
|     def get_parser(self, prog_name):
 | |
|         parser = super(CreateBackup, self).get_parser(prog_name)
 | |
|         parser.add_argument(
 | |
|             "volume",
 | |
|             metavar="<volume>",
 | |
|             help="Volume to backup (name or ID)"
 | |
|         )
 | |
|         parser.add_argument(
 | |
|             "--name",
 | |
|             metavar="<name>",
 | |
|             required=True,
 | |
|             help="Name of the backup"
 | |
|         )
 | |
|         parser.add_argument(
 | |
|             "--description",
 | |
|             metavar="<description>",
 | |
|             help="Description of the backup"
 | |
|         )
 | |
|         parser.add_argument(
 | |
|             "--container",
 | |
|             metavar="<container>",
 | |
|             help="Optional backup container name"
 | |
|         )
 | |
|         return parser
 | |
| 
 | |
|     def take_action(self, parsed_args):
 | |
|         volume_client = self.app.client_manager.volume
 | |
|         volume_id = utils.find_resource(
 | |
|             volume_client.volumes, parsed_args.volume).id
 | |
|         backup = volume_client.backups.create(
 | |
|             volume_id,
 | |
|             container=parsed_args.container,
 | |
|             name=parsed_args.name,
 | |
|             description=parsed_args.description
 | |
|         )
 | |
|         backup._info.pop("links", None)
 | |
|         return zip(*sorted(six.iteritems(backup._info)))
 | |
| 
 | |
| 
 | |
| class DeleteBackup(command.Command):
 | |
|     """Delete backup(s)"""
 | |
| 
 | |
|     def get_parser(self, prog_name):
 | |
|         parser = super(DeleteBackup, self).get_parser(prog_name)
 | |
|         parser.add_argument(
 | |
|             "backups",
 | |
|             metavar="<backup>",
 | |
|             nargs="+",
 | |
|             help="Backup(s) to delete (name or ID)"
 | |
|         )
 | |
|         return parser
 | |
| 
 | |
|     def take_action(self, parsed_args):
 | |
|         volume_client = self.app.client_manager.volume
 | |
|         for backup in parsed_args.backups:
 | |
|             backup_id = utils.find_resource(
 | |
|                 volume_client.backups, backup).id
 | |
|             volume_client.backups.delete(backup_id)
 | |
| 
 | |
| 
 | |
| class ListBackup(command.Lister):
 | |
|     """List backups"""
 | |
| 
 | |
|     def get_parser(self, prog_name):
 | |
|         parser = super(ListBackup, self).get_parser(prog_name)
 | |
|         parser.add_argument(
 | |
|             "--long",
 | |
|             action="store_true",
 | |
|             default=False,
 | |
|             help="List additional fields in output"
 | |
|         )
 | |
|         return parser
 | |
| 
 | |
|     def take_action(self, parsed_args):
 | |
| 
 | |
|         def _format_volume_id(volume_id):
 | |
|             """Return a volume name if available
 | |
| 
 | |
|             :param volume_id: a volume ID
 | |
|             :rtype: either the volume ID or name
 | |
|             """
 | |
| 
 | |
|             volume = volume_id
 | |
|             if volume_id in volume_cache.keys():
 | |
|                 volume = volume_cache[volume_id].name
 | |
|             return volume
 | |
| 
 | |
|         if parsed_args.long:
 | |
|             columns = ['ID', 'Name', 'Description', 'Status', 'Size',
 | |
|                        'Availability Zone', 'Volume ID', 'Container']
 | |
|             column_headers = copy.deepcopy(columns)
 | |
|             column_headers[6] = 'Volume'
 | |
|         else:
 | |
|             columns = ['ID', 'Name', 'Description', 'Status', 'Size']
 | |
|             column_headers = columns
 | |
| 
 | |
|         # Cache the volume list
 | |
|         volume_cache = {}
 | |
|         try:
 | |
|             for s in self.app.client_manager.volume.volumes.list():
 | |
|                 volume_cache[s.id] = s
 | |
|         except Exception:
 | |
|             # Just forget it if there's any trouble
 | |
|             pass
 | |
| 
 | |
|         data = self.app.client_manager.volume.backups.list()
 | |
| 
 | |
|         return (column_headers,
 | |
|                 (utils.get_item_properties(
 | |
|                     s, columns,
 | |
|                     formatters={'Volume ID': _format_volume_id},
 | |
|                 ) for s in data))
 | |
| 
 | |
| 
 | |
| class RestoreBackup(command.ShowOne):
 | |
|     """Restore backup"""
 | |
| 
 | |
|     def get_parser(self, prog_name):
 | |
|         parser = super(RestoreBackup, self).get_parser(prog_name)
 | |
|         parser.add_argument(
 | |
|             "backup",
 | |
|             metavar="<backup>",
 | |
|             help="Backup to restore (ID only)"
 | |
|         )
 | |
|         parser.add_argument(
 | |
|             "volume",
 | |
|             metavar="<volume>",
 | |
|             help="Volume to restore to (name or ID)"
 | |
|         )
 | |
|         return parser
 | |
| 
 | |
|     def take_action(self, parsed_args):
 | |
|         volume_client = self.app.client_manager.volume
 | |
|         backup = utils.find_resource(volume_client.backups, parsed_args.backup)
 | |
|         destination_volume = utils.find_resource(volume_client.volumes,
 | |
|                                                  parsed_args.volume)
 | |
|         return volume_client.restores.restore(backup.id, destination_volume.id)
 | |
| 
 | |
| 
 | |
| class ShowBackup(command.ShowOne):
 | |
|     """Display backup details"""
 | |
| 
 | |
|     def get_parser(self, prog_name):
 | |
|         parser = super(ShowBackup, self).get_parser(prog_name)
 | |
|         parser.add_argument(
 | |
|             "backup",
 | |
|             metavar="<backup>",
 | |
|             help="Backup to display (name or ID)")
 | |
|         return parser
 | |
| 
 | |
|     def take_action(self, parsed_args):
 | |
|         volume_client = self.app.client_manager.volume
 | |
|         backup = utils.find_resource(volume_client.backups,
 | |
|                                      parsed_args.backup)
 | |
|         backup._info.pop("links", None)
 | |
|         return zip(*sorted(six.iteritems(backup._info)))
 |