Previously each command logs take_action parameters explicitly by using @utils.log_method decorator or log.debug(). Some commands have no logging. This commit calls a logger in the base class and drops all logging definition from individual commands. Closes-Bug: #1532294 Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
		
			
				
	
	
		
			109 lines
		
	
	
		
			3.3 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			109 lines
		
	
	
		
			3.3 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
#   Copyright 2013 OpenStack, LLC.
 | 
						|
#
 | 
						|
#   Licensed under the Apache License, Version 2.0 (the "License"); you may
 | 
						|
#   not use this file except in compliance with the License. You may obtain
 | 
						|
#   a copy of the License at
 | 
						|
#
 | 
						|
#        http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
#
 | 
						|
#   Unless required by applicable law or agreed to in writing, software
 | 
						|
#   distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 | 
						|
#   WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 | 
						|
#   License for the specific language governing permissions and limitations
 | 
						|
#   under the License.
 | 
						|
#
 | 
						|
 | 
						|
"""Service action implementations"""
 | 
						|
 | 
						|
from openstackclient.common import command
 | 
						|
from openstackclient.common import utils
 | 
						|
 | 
						|
 | 
						|
class DeleteService(command.Command):
 | 
						|
    """Delete service command"""
 | 
						|
 | 
						|
    def get_parser(self, prog_name):
 | 
						|
        parser = super(DeleteService, self).get_parser(prog_name)
 | 
						|
        parser.add_argument(
 | 
						|
            "service",
 | 
						|
            metavar="<service>",
 | 
						|
            help="Compute service to delete (ID only)")
 | 
						|
        return parser
 | 
						|
 | 
						|
    def take_action(self, parsed_args):
 | 
						|
        compute_client = self.app.client_manager.compute
 | 
						|
 | 
						|
        compute_client.services.delete(parsed_args.service)
 | 
						|
 | 
						|
 | 
						|
class ListService(command.Lister):
 | 
						|
    """List service command"""
 | 
						|
 | 
						|
    def get_parser(self, prog_name):
 | 
						|
        parser = super(ListService, self).get_parser(prog_name)
 | 
						|
        parser.add_argument(
 | 
						|
            "--host",
 | 
						|
            metavar="<host>",
 | 
						|
            help="Name of host")
 | 
						|
        parser.add_argument(
 | 
						|
            "--service",
 | 
						|
            metavar="<service>",
 | 
						|
            help="Name of service")
 | 
						|
        return parser
 | 
						|
 | 
						|
    def take_action(self, parsed_args):
 | 
						|
        compute_client = self.app.client_manager.compute
 | 
						|
        columns = (
 | 
						|
            "Id",
 | 
						|
            "Binary",
 | 
						|
            "Host",
 | 
						|
            "Zone",
 | 
						|
            "Status",
 | 
						|
            "State",
 | 
						|
            "Updated At"
 | 
						|
        )
 | 
						|
        data = compute_client.services.list(parsed_args.host,
 | 
						|
                                            parsed_args.service)
 | 
						|
        return (columns,
 | 
						|
                (utils.get_item_properties(
 | 
						|
                    s, columns,
 | 
						|
                ) for s in data))
 | 
						|
 | 
						|
 | 
						|
class SetService(command.Command):
 | 
						|
    """Set service command"""
 | 
						|
 | 
						|
    def get_parser(self, prog_name):
 | 
						|
        parser = super(SetService, self).get_parser(prog_name)
 | 
						|
        parser.add_argument(
 | 
						|
            "host",
 | 
						|
            metavar="<host>",
 | 
						|
            help="Name of host")
 | 
						|
        parser.add_argument(
 | 
						|
            "service",
 | 
						|
            metavar="<service>",
 | 
						|
            help="Name of service")
 | 
						|
        enabled_group = parser.add_mutually_exclusive_group()
 | 
						|
        enabled_group.add_argument(
 | 
						|
            "--enable",
 | 
						|
            dest="enabled",
 | 
						|
            default=True,
 | 
						|
            help="Enable a service (default)",
 | 
						|
            action="store_true")
 | 
						|
        enabled_group.add_argument(
 | 
						|
            "--disable",
 | 
						|
            dest="enabled",
 | 
						|
            help="Disable a service",
 | 
						|
            action="store_false")
 | 
						|
        return parser
 | 
						|
 | 
						|
    def take_action(self, parsed_args):
 | 
						|
        compute_client = self.app.client_manager.compute
 | 
						|
 | 
						|
        if parsed_args.enabled:
 | 
						|
            action = compute_client.services.enable
 | 
						|
        else:
 | 
						|
            action = compute_client.services.disable
 | 
						|
 | 
						|
        action(parsed_args.host, parsed_args.service)
 |