26d50be79a
Supporting "--no-property" option will apply user a convenient way to clean all properties of volume snapshot in a short command, and this kind of behavior is the recommended way to devref. The patch adds "--no-property" option in "volume snapshot set" command, and update related test cases and devref document. Change-Id: I5f10cc2b5814553699920c4343995b2e11416e4e Implements: blueprint allow-overwrite-set-options
356 lines
12 KiB
Python
356 lines
12 KiB
Python
# Copyright 2012-2013 OpenStack Foundation
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
"""Volume v1 Snapshot action implementations"""
|
|
|
|
import copy
|
|
import logging
|
|
|
|
from osc_lib.cli import parseractions
|
|
from osc_lib.command import command
|
|
from osc_lib import exceptions
|
|
from osc_lib import utils
|
|
import six
|
|
|
|
from openstackclient.i18n import _
|
|
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
class CreateVolumeSnapshot(command.ShowOne):
|
|
_description = _("Create new volume snapshot")
|
|
|
|
def get_parser(self, prog_name):
|
|
parser = super(CreateVolumeSnapshot, self).get_parser(prog_name)
|
|
parser.add_argument(
|
|
'snapshot_name',
|
|
metavar='<snapshot-name>',
|
|
nargs="?",
|
|
help=_('Name of the snapshot (default to None)'),
|
|
)
|
|
parser.add_argument(
|
|
'--volume',
|
|
metavar='<volume>',
|
|
help=_('Volume to snapshot (name or ID) '
|
|
'(default is <snapshot-name>)'),
|
|
)
|
|
parser.add_argument(
|
|
'--description',
|
|
metavar='<description>',
|
|
help=_('Description of the snapshot'),
|
|
)
|
|
parser.add_argument(
|
|
'--force',
|
|
dest='force',
|
|
action='store_true',
|
|
default=False,
|
|
help=_('Create a snapshot attached to an instance. '
|
|
'Default is False'),
|
|
)
|
|
return parser
|
|
|
|
def take_action(self, parsed_args):
|
|
volume_client = self.app.client_manager.volume
|
|
volume = parsed_args.volume
|
|
if not parsed_args.volume:
|
|
volume = parsed_args.snapshot_name
|
|
volume_id = utils.find_resource(volume_client.volumes,
|
|
volume).id
|
|
snapshot = volume_client.volume_snapshots.create(
|
|
volume_id,
|
|
parsed_args.force,
|
|
parsed_args.snapshot_name,
|
|
parsed_args.description
|
|
)
|
|
|
|
snapshot._info.update(
|
|
{'properties': utils.format_dict(snapshot._info.pop('metadata'))}
|
|
)
|
|
|
|
return zip(*sorted(six.iteritems(snapshot._info)))
|
|
|
|
|
|
class DeleteVolumeSnapshot(command.Command):
|
|
_description = _("Delete volume snapshot(s)")
|
|
|
|
def get_parser(self, prog_name):
|
|
parser = super(DeleteVolumeSnapshot, self).get_parser(prog_name)
|
|
parser.add_argument(
|
|
'snapshots',
|
|
metavar='<snapshot>',
|
|
nargs="+",
|
|
help=_('Snapshot(s) to delete (name or ID)'),
|
|
)
|
|
return parser
|
|
|
|
def take_action(self, parsed_args):
|
|
volume_client = self.app.client_manager.volume
|
|
result = 0
|
|
|
|
for i in parsed_args.snapshots:
|
|
try:
|
|
snapshot_id = utils.find_resource(
|
|
volume_client.volume_snapshots, i).id
|
|
volume_client.volume_snapshots.delete(snapshot_id)
|
|
except Exception as e:
|
|
result += 1
|
|
LOG.error(_("Failed to delete snapshot with "
|
|
"name or ID '%(snapshot)s': %(e)s"),
|
|
{'snapshot': i, 'e': e})
|
|
|
|
if result > 0:
|
|
total = len(parsed_args.snapshots)
|
|
msg = (_("%(result)s of %(total)s snapshots failed "
|
|
"to delete.") % {'result': result, 'total': total})
|
|
raise exceptions.CommandError(msg)
|
|
|
|
|
|
class ListVolumeSnapshot(command.Lister):
|
|
_description = _("List volume snapshots")
|
|
|
|
def get_parser(self, prog_name):
|
|
parser = super(ListVolumeSnapshot, self).get_parser(prog_name)
|
|
parser.add_argument(
|
|
'--all-projects',
|
|
action='store_true',
|
|
default=False,
|
|
help=_('Include all projects (admin only)'),
|
|
)
|
|
parser.add_argument(
|
|
'--long',
|
|
action='store_true',
|
|
default=False,
|
|
help=_('List additional fields in output'),
|
|
)
|
|
parser.add_argument(
|
|
'--name',
|
|
metavar='<name>',
|
|
default=None,
|
|
help=_('Filters results by a name.')
|
|
)
|
|
parser.add_argument(
|
|
'--status',
|
|
metavar='<status>',
|
|
choices=['available', 'error', 'creating', 'deleting',
|
|
'error-deleting'],
|
|
help=_("Filters results by a status. "
|
|
"('available', 'error', 'creating', 'deleting'"
|
|
" or 'error-deleting')")
|
|
)
|
|
parser.add_argument(
|
|
'--volume',
|
|
metavar='<volume>',
|
|
default=None,
|
|
help=_('Filters results by a volume (name or ID).')
|
|
)
|
|
return parser
|
|
|
|
def take_action(self, parsed_args):
|
|
volume_client = self.app.client_manager.volume
|
|
|
|
def _format_volume_id(volume_id):
|
|
"""Return a volume name if available
|
|
|
|
:param volume_id: a volume ID
|
|
:rtype: either the volume ID or name
|
|
"""
|
|
|
|
volume = volume_id
|
|
if volume_id in volume_cache.keys():
|
|
volume = volume_cache[volume_id].display_name
|
|
return volume
|
|
|
|
if parsed_args.long:
|
|
columns = ['ID', 'Display Name', 'Display Description', 'Status',
|
|
'Size', 'Created At', 'Volume ID', 'Metadata']
|
|
column_headers = copy.deepcopy(columns)
|
|
column_headers[6] = 'Volume'
|
|
column_headers[7] = 'Properties'
|
|
else:
|
|
columns = ['ID', 'Display Name', 'Display Description', 'Status',
|
|
'Size']
|
|
column_headers = copy.deepcopy(columns)
|
|
|
|
# Always update Name and Description
|
|
column_headers[1] = 'Name'
|
|
column_headers[2] = 'Description'
|
|
|
|
# Cache the volume list
|
|
volume_cache = {}
|
|
try:
|
|
for s in volume_client.volumes.list():
|
|
volume_cache[s.id] = s
|
|
except Exception:
|
|
# Just forget it if there's any trouble
|
|
pass
|
|
|
|
volume_id = None
|
|
if parsed_args.volume:
|
|
volume_id = utils.find_resource(
|
|
volume_client.volumes, parsed_args.volume).id
|
|
|
|
search_opts = {
|
|
'all_tenants': parsed_args.all_projects,
|
|
'display_name': parsed_args.name,
|
|
'status': parsed_args.status,
|
|
'volume_id': volume_id,
|
|
}
|
|
|
|
data = volume_client.volume_snapshots.list(
|
|
search_opts=search_opts)
|
|
return (column_headers,
|
|
(utils.get_item_properties(
|
|
s, columns,
|
|
formatters={'Metadata': utils.format_dict,
|
|
'Volume ID': _format_volume_id},
|
|
) for s in data))
|
|
|
|
|
|
class SetVolumeSnapshot(command.Command):
|
|
_description = _("Set volume snapshot properties")
|
|
|
|
def get_parser(self, prog_name):
|
|
parser = super(SetVolumeSnapshot, self).get_parser(prog_name)
|
|
parser.add_argument(
|
|
'snapshot',
|
|
metavar='<snapshot>',
|
|
help=_('Snapshot to modify (name or ID)')
|
|
)
|
|
parser.add_argument(
|
|
'--name',
|
|
metavar='<name>',
|
|
help=_('New snapshot name')
|
|
)
|
|
parser.add_argument(
|
|
'--description',
|
|
metavar='<description>',
|
|
help=_('New snapshot description')
|
|
)
|
|
parser.add_argument(
|
|
"--no-property",
|
|
dest="no_property",
|
|
action="store_true",
|
|
help=_("Remove all properties from <snapshot> "
|
|
"(specify both --no-property and --property to "
|
|
"remove the current properties before setting "
|
|
"new properties.)"),
|
|
)
|
|
parser.add_argument(
|
|
'--property',
|
|
metavar='<key=value>',
|
|
action=parseractions.KeyValueAction,
|
|
help=_('Property to add/change for this snapshot '
|
|
'(repeat option to set multiple properties)'),
|
|
)
|
|
return parser
|
|
|
|
def take_action(self, parsed_args):
|
|
volume_client = self.app.client_manager.volume
|
|
snapshot = utils.find_resource(volume_client.volume_snapshots,
|
|
parsed_args.snapshot)
|
|
|
|
result = 0
|
|
if parsed_args.no_property:
|
|
try:
|
|
key_list = snapshot.metadata.keys()
|
|
volume_client.volume_snapshots.delete_metadata(
|
|
snapshot.id,
|
|
list(key_list),
|
|
)
|
|
except Exception as e:
|
|
LOG.error(_("Failed to clean snapshot properties: %s"), e)
|
|
result += 1
|
|
|
|
if parsed_args.property:
|
|
try:
|
|
volume_client.volume_snapshots.set_metadata(
|
|
snapshot.id, parsed_args.property)
|
|
except Exception as e:
|
|
LOG.error(_("Failed to set snapshot property: %s"), e)
|
|
result += 1
|
|
|
|
kwargs = {}
|
|
if parsed_args.name:
|
|
kwargs['display_name'] = parsed_args.name
|
|
if parsed_args.description:
|
|
kwargs['display_description'] = parsed_args.description
|
|
if kwargs:
|
|
try:
|
|
snapshot.update(**kwargs)
|
|
except Exception as e:
|
|
LOG.error(_("Failed to update snapshot display name "
|
|
"or display description: %s"), e)
|
|
result += 1
|
|
|
|
if result > 0:
|
|
raise exceptions.CommandError(_("One or more of the "
|
|
"set operations failed"))
|
|
|
|
|
|
class ShowVolumeSnapshot(command.ShowOne):
|
|
_description = _("Display volume snapshot details")
|
|
|
|
def get_parser(self, prog_name):
|
|
parser = super(ShowVolumeSnapshot, self).get_parser(prog_name)
|
|
parser.add_argument(
|
|
'snapshot',
|
|
metavar='<snapshot>',
|
|
help=_('Snapshot to display (name or ID)')
|
|
)
|
|
return parser
|
|
|
|
def take_action(self, parsed_args):
|
|
volume_client = self.app.client_manager.volume
|
|
snapshot = utils.find_resource(volume_client.volume_snapshots,
|
|
parsed_args.snapshot)
|
|
|
|
snapshot._info.update(
|
|
{'properties': utils.format_dict(snapshot._info.pop('metadata'))}
|
|
)
|
|
|
|
return zip(*sorted(six.iteritems(snapshot._info)))
|
|
|
|
|
|
class UnsetVolumeSnapshot(command.Command):
|
|
_description = _("Unset volume snapshot properties")
|
|
|
|
def get_parser(self, prog_name):
|
|
parser = super(UnsetVolumeSnapshot, self).get_parser(prog_name)
|
|
parser.add_argument(
|
|
'snapshot',
|
|
metavar='<snapshot>',
|
|
help=_('Snapshot to modify (name or ID)'),
|
|
)
|
|
parser.add_argument(
|
|
'--property',
|
|
metavar='<key>',
|
|
action='append',
|
|
help=_('Property to remove from snapshot '
|
|
'(repeat option to remove multiple properties)'),
|
|
)
|
|
return parser
|
|
|
|
def take_action(self, parsed_args):
|
|
volume_client = self.app.client_manager.volume
|
|
snapshot = utils.find_resource(
|
|
volume_client.volume_snapshots, parsed_args.snapshot)
|
|
|
|
if parsed_args.property:
|
|
volume_client.volume_snapshots.delete_metadata(
|
|
snapshot.id,
|
|
parsed_args.property,
|
|
)
|