From faf22a183293c1bc6851382a668a5073a46baa21 Mon Sep 17 00:00:00 2001 From: Everett Toews Date: Tue, 7 Jul 2015 10:41:48 -0500 Subject: [PATCH] Don't allow users to set all API versions the same Setting all API versions to be the same is totally unrealistic. As such it's confusing to have code that allows something that's totally unrealistic. Let's remove things that will never ever happen. Change-Id: Ie7cab8ec60b17262183e034d01bb648d28bb7ad1 --- openstack/profile.py | 7 +------ openstack/tests/unit/test_profile.py | 2 -- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/openstack/profile.py b/openstack/profile.py index 9f749a66..be1db392 100644 --- a/openstack/profile.py +++ b/openstack/profile.py @@ -190,12 +190,7 @@ class Profile(object): :param str service: Service type. :param str version: Desired service version. """ - if service == self.ALL: - services = self.service_names - else: - services = [service] - for service in services: - self._get_service(service).version = version + self._get_service(service).version = version def set_visibility(self, service, visibility): """Set the desired visibility for the specified service. diff --git a/openstack/tests/unit/test_profile.py b/openstack/tests/unit/test_profile.py index 4fb39e0f..177e7c76 100644 --- a/openstack/tests/unit/test_profile.py +++ b/openstack/tests/unit/test_profile.py @@ -77,10 +77,8 @@ class TestProfile(base.TestCase): prof = profile.Profile() prof.set_name(prof.ALL, 'fee') prof.set_region(prof.ALL, 'fie') - prof.set_version(prof.ALL, 'foe') prof.set_visibility(prof.ALL, 'public') for service in prof.service_names: self.assertEqual('fee', prof.get_preference(service).service_name) self.assertEqual('fie', prof.get_preference(service).region) - self.assertEqual('foe', prof.get_preference(service).version) self.assertEqual('public', prof.get_preference(service).visibility)