5bb3cb0e27
This change brings a few more test methods to consistency in ordering of arguments and the use of the default mock_method argument. Note: this doesn't touch verify_find yet because the implementations don't use BaseProxy, yet. Change-Id: I27d3e8d43a5406b24e9b82fa3c59c60ad8e6c3f0
173 lines
7.7 KiB
Python
173 lines
7.7 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
|
|
from openstack.tests.unit import base
|
|
|
|
|
|
class TestProxyBase(base.TestCase):
|
|
def setUp(self):
|
|
super(TestProxyBase, self).setUp()
|
|
self.session = mock.MagicMock()
|
|
|
|
def _verify(self, mock_method, test_method,
|
|
method_args=None, method_kwargs=None,
|
|
expected_args=None, expected_kwargs=None,
|
|
expected_result=None):
|
|
with mock.patch(mock_method) as mocked:
|
|
mocked.return_value = expected_result
|
|
if any([method_args, method_kwargs,
|
|
expected_args, expected_kwargs]):
|
|
method_args = method_args or ()
|
|
method_kwargs = method_kwargs or {}
|
|
expected_args = expected_args or ()
|
|
expected_kwargs = expected_kwargs or {}
|
|
|
|
self.assertEqual(expected_result, test_method(*method_args,
|
|
**method_kwargs))
|
|
mocked.assert_called_with(self.session,
|
|
*expected_args, **expected_kwargs)
|
|
else:
|
|
self.assertEqual(expected_result, test_method())
|
|
mocked.assert_called_with(self.session)
|
|
|
|
# NOTE(briancurtin): This is a duplicate version of _verify that is
|
|
# temporarily here while we shift APIs. The difference is that
|
|
# calls from the Proxy classes aren't going to be going directly into
|
|
# the Resource layer anymore, so they don't pass in the session which
|
|
# was tested in assert_called_with.
|
|
# This is being done in lieu of adding logic and complicating
|
|
# the _verify method. It will be removed once there is one API to
|
|
# be verifying.
|
|
def _verify2(self, mock_method, test_method,
|
|
method_args=None, method_kwargs=None,
|
|
expected_args=None, expected_kwargs=None,
|
|
expected_result=None):
|
|
with mock.patch(mock_method) as mocked:
|
|
mocked.return_value = expected_result
|
|
if any([method_args, method_kwargs,
|
|
expected_args, expected_kwargs]):
|
|
method_args = method_args or ()
|
|
method_kwargs = method_kwargs or {}
|
|
expected_args = expected_args or ()
|
|
expected_kwargs = expected_kwargs or {}
|
|
|
|
self.assertEqual(expected_result, test_method(*method_args,
|
|
**method_kwargs))
|
|
mocked.assert_called_with(*expected_args, **expected_kwargs)
|
|
else:
|
|
self.assertEqual(expected_result, test_method())
|
|
mocked.assert_called_with(self.session)
|
|
|
|
def verify_create(self, test_method, resource_type,
|
|
mock_method="openstack.proxy.BaseProxy._create",
|
|
expected_result="result", **kwargs):
|
|
the_kwargs = {"x": 1, "y": 2, "z": 3}
|
|
method_kwargs = the_kwargs
|
|
expected_args = [resource_type]
|
|
expected_kwargs = the_kwargs
|
|
|
|
self._verify2(mock_method, test_method,
|
|
expected_result=expected_result,
|
|
method_kwargs=method_kwargs,
|
|
expected_args=expected_args,
|
|
expected_kwargs=expected_kwargs,
|
|
**kwargs)
|
|
|
|
def verify_delete(self, test_method, resource_type, ignore,
|
|
input_path_args=None, expected_path_args=None,
|
|
mock_method="openstack.proxy.BaseProxy._delete"):
|
|
method_kwargs = {"ignore_missing": ignore}
|
|
if isinstance(input_path_args, dict):
|
|
for key in input_path_args:
|
|
method_kwargs[key] = input_path_args[key]
|
|
expected_kwargs = {"ignore_missing": ignore}
|
|
if expected_path_args:
|
|
expected_kwargs["path_args"] = expected_path_args
|
|
self._verify2(mock_method, test_method,
|
|
method_args=["resource_or_id"],
|
|
method_kwargs=method_kwargs,
|
|
expected_args=[resource_type, "resource_or_id"],
|
|
expected_kwargs=expected_kwargs)
|
|
|
|
def verify_get(self, test_method, resource_type, value=None,
|
|
mock_method="openstack.proxy.BaseProxy._get", **kwargs):
|
|
the_value = value if value is not None else ["value"]
|
|
expected_kwargs = {"path_args": kwargs} if kwargs else {}
|
|
self._verify2(mock_method, test_method,
|
|
method_args=the_value,
|
|
method_kwargs=kwargs,
|
|
expected_args=[resource_type] + the_value,
|
|
expected_kwargs=expected_kwargs)
|
|
|
|
def verify_head(self, test_method, resource_type,
|
|
mock_method="openstack.proxy.BaseProxy._head",
|
|
value=None, **kwargs):
|
|
the_value = [value] if value is not None else []
|
|
expected_kwargs = {"path_args": kwargs} if kwargs else {}
|
|
self._verify2(mock_method, test_method,
|
|
method_args=the_value,
|
|
method_kwargs=kwargs,
|
|
expected_args=[resource_type] + the_value,
|
|
expected_kwargs=expected_kwargs)
|
|
|
|
def verify_find(self, mock_method, test_method, **kwargs):
|
|
self._verify(mock_method, test_method, method_args=["name_or_id"],
|
|
expected_args=["name_or_id"], expected_result="result",
|
|
**kwargs)
|
|
|
|
def verify_find2(self, mock_method, test_method, path_args, **kwargs):
|
|
method_args = ["name_or_id"]
|
|
for key in path_args:
|
|
method_args.append(path_args[key])
|
|
|
|
self._verify(mock_method, test_method,
|
|
method_args=method_args,
|
|
expected_args=["name_or_id"],
|
|
expected_kwargs={"path_args": path_args},
|
|
expected_result="result",
|
|
**kwargs)
|
|
|
|
def verify_list(self, test_method, resource_type, paginated=False,
|
|
mock_method="openstack.proxy.BaseProxy._list",
|
|
**kwargs):
|
|
expected_kwargs = kwargs.pop("expected_kwargs", {})
|
|
expected_kwargs.update({"paginated": paginated})
|
|
self._verify2(mock_method, test_method,
|
|
expected_args=[resource_type],
|
|
expected_kwargs=expected_kwargs,
|
|
expected_result=["result"],
|
|
**kwargs)
|
|
|
|
def verify_update(self, test_method, resource_type,
|
|
mock_method="openstack.proxy.BaseProxy._update",
|
|
expected_result="result", **kwargs):
|
|
the_kwargs = {"x": 1, "y": 2, "z": 3}
|
|
method_args = ["resource_or_id"]
|
|
method_kwargs = the_kwargs
|
|
expected_args = [resource_type, "resource_or_id"]
|
|
expected_kwargs = the_kwargs
|
|
|
|
self._verify2(mock_method, test_method,
|
|
expected_result=expected_result,
|
|
method_args=method_args,
|
|
method_kwargs=method_kwargs,
|
|
expected_args=expected_args,
|
|
expected_kwargs=expected_kwargs,
|
|
**kwargs)
|
|
|
|
def verify_wait_for_status(
|
|
self, test_method,
|
|
mock_method="openstack.resource.wait_for_status", **kwargs):
|
|
self._verify(mock_method, test_method, **kwargs)
|