openstack/deb-python-os-brick
Code Issues Proposed changes

Revert "Don't use ignoreskipactivation for thin LVM"

Browse Source 
Commit b82ab0d1a0 wrongly assumed that
the "ignoreskipactivation" flag is not needed when using thin LVM
provisioning. This is wrong.
Using thin LVM leads now to an error when the content will be copied:

ERROR cinder.volume.manager Command: sudo cinder-rootwrap /etc/cinder/
      rootwrap.conf dd if=/dev/mapper/cinder--volumes-_snapshot--UUID
      of=/dev/mapper/cinder--volumes-volume--UUID
      count=1073741824 bs=1M iflag=count_bytes conv=sparse

The reason is that the the snapshot is not activated and due to that,
no device node is available under /dev/mapper .

This reverts commit b82ab0d1a0 and makes
thin provisioning for LVM working again.

Change-Id: I062fd7d7120081c79c714d8177104cdd95522d2d
Depends-On: I788b297af92e11063b18c05a415b6f4d4d4bcd2c
Closes-Bug: #1702322
Related-Bug: #1701545
This commit is contained in:
Thomas Bechtold 2017-07-04 15:10:22 +00:00 committed by Eric Harney
parent b82ab0d1a0
commit 925f435cb9
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
os_brick/local_dev/lvm.py
View File

@ -681,8 +681,7 @@ class LVM(executor.Executor):
# and fails.
cmd = ['lvchange', '-a', 'y', '--yes']
if (self.supports_lvchange_ignoreskipactivation and
self.vg_thin_pool is None):
if self.supports_lvchange_ignoreskipactivation:
cmd.append('-K')
# If permanent=True is specified, drop the skipactivation flag in
# order to make this LV automatically activated after next reboot.