openstack
/
deb-python-os-brick
Code Issues Proposed changes

Update notes for submitted changes 

* Updated from global requirements
* Raise specific exception for an invalid protocol connector
* Change assertTrue(isinstance()) with optimal assert
This commit is contained in:
Gerrit Code Review 2016-11-08 14:02:36 +00:00
parent c79df42783
commit ff2a21e352
3 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
9b561506d5f995906953182f0ef9c857c3ccf18b Normal file
View File

@ -0,0 +1,10 @@
Code-Review+2: Walter A. Boring IV (hemna) <waboring@hemna.com>
Code-Review+1: Kendall Nelson <kennelson11@gmail.com>
Code-Review+2: Eric Harney <eharney@redhat.com>
Workflow+1: Eric Harney <eharney@redhat.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Mon, 07 Nov 2016 17:51:16 +0000
Reviewed-on: https://review.openstack.org/364158
Project: openstack/deb-python-os-brick
Branch: refs/heads/master

9
dbde8fee8e80df11b2136ce27cc472734949aeb5 Normal file
View File

@ -0,0 +1,9 @@
Code-Review+2: Sean McGinnis <sean.mcginnis@gmail.com>
Code-Review+2: Walter A. Boring IV (hemna) <waboring@hemna.com>
Workflow+1: Walter A. Boring IV (hemna) <waboring@hemna.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Mon, 07 Nov 2016 23:23:56 +0000
Reviewed-on: https://review.openstack.org/394104
Project: openstack/deb-python-os-brick
Branch: refs/heads/master

11
f7b8d242f7125242eebf0f72532daa931d5bb59f Normal file
View File

@ -0,0 +1,11 @@
Code-Review+2: John Griffith <john.griffith8@gmail.com>
Code-Review+1: Arne Recknagel <arecknag@de.ibm.com>
Code-Review+1: sahid <sahid.ferdjaoui@redhat.com>
Code-Review+2: Walter A. Boring IV (hemna) <waboring@hemna.com>
Workflow+1: Walter A. Boring IV (hemna) <waboring@hemna.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Mon, 07 Nov 2016 22:37:52 +0000
Reviewed-on: https://review.openstack.org/393941
Project: openstack/deb-python-os-brick
Branch: refs/heads/master