From 55624ad8677a12d478461e041af55a59ba975861 Mon Sep 17 00:00:00 2001
From: Steve Kowalik <steven@wedontsleep.org>
Date: Wed, 23 Jul 2014 10:46:45 -0400
Subject: [PATCH] Drop use of simplejson, switching to json

After being brought up in multiple reviews, switch to using the
built-in json module rather than simplejson. Adios, and the horse
you rode in on, simplejson.

Change-Id: I2c590f18c17492a1cc9234fa97ab499f806d91d4
---
 os_cloud_config/cmd/register_nodes.py      | 4 ++--
 os_cloud_config/keystone_pki.py            | 6 +++---
 os_cloud_config/tests/test_keystone_pki.py | 6 +++---
 requirements.txt                           | 1 -
 4 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/os_cloud_config/cmd/register_nodes.py b/os_cloud_config/cmd/register_nodes.py
index ebd12fa..4d8d91e 100644
--- a/os_cloud_config/cmd/register_nodes.py
+++ b/os_cloud_config/cmd/register_nodes.py
@@ -14,7 +14,7 @@
 # limitations under the License.
 
 import argparse
-import simplejson
+import json
 import textwrap
 
 from os_cloud_config import nodes
@@ -52,7 +52,7 @@ def main():
 
     try:
         with open(args.nodes, 'r') as node_file:
-            nodes_list = simplejson.load(node_file)
+            nodes_list = json.load(node_file)
         utils._ensure_environment()
 
         # TODO(StevenK): Filter out registered nodes.
diff --git a/os_cloud_config/keystone_pki.py b/os_cloud_config/keystone_pki.py
index 6f1d74b..04dafca 100644
--- a/os_cloud_config/keystone_pki.py
+++ b/os_cloud_config/keystone_pki.py
@@ -12,10 +12,10 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+import json
 import logging
 import os
 from os import path
-import simplejson
 import stat
 
 from OpenSSL import crypto
@@ -152,7 +152,7 @@ def generate_certs_into_json(jsonfile, seed):
     """
     if os.path.isfile(jsonfile):
         with open(jsonfile) as json_fd:
-            all_data = simplejson.load(json_fd)
+            all_data = json.load(json_fd)
     else:
         all_data = {}
 
@@ -181,7 +181,7 @@ def generate_certs_into_json(jsonfile, seed):
                             signing_key_name: signing_key_pem,
                             signing_cert_name: signing_cert_pem})
         with open(jsonfile, 'w') as json_fd:
-            simplejson.dump(all_data, json_fd, sort_keys=True)
+            json.dump(all_data, json_fd, sort_keys=True)
             LOG.debug("Wrote key/certs into '%s'.", path.abspath(jsonfile))
     else:
         LOG.info("Key/certs are already present in '%s', skipping.",
diff --git a/os_cloud_config/tests/test_keystone_pki.py b/os_cloud_config/tests/test_keystone_pki.py
index 314586e..5f81a67 100644
--- a/os_cloud_config/tests/test_keystone_pki.py
+++ b/os_cloud_config/tests/test_keystone_pki.py
@@ -103,7 +103,7 @@ class KeystonePKITest(base.TestCase):
     @mock.patch('os_cloud_config.keystone_pki.create_ca_pair')
     @mock.patch('os_cloud_config.keystone_pki.create_signing_pair')
     @mock.patch('os_cloud_config.keystone_pki.open', create=True)
-    @mock.patch('os_cloud_config.keystone_pki.simplejson.dump')
+    @mock.patch('os_cloud_config.keystone_pki.json.dump')
     def test_generate_certs_into_json(
         self, mock_json, open_, create_signing, create_ca, isfile):
         create_ca.return_value = ('mock_ca_key', 'mock_ca_cert')
@@ -122,8 +122,8 @@ class KeystonePKITest(base.TestCase):
     @mock.patch('os_cloud_config.keystone_pki.create_ca_pair')
     @mock.patch('os_cloud_config.keystone_pki.create_signing_pair')
     @mock.patch('os_cloud_config.keystone_pki.open', create=True)
-    @mock.patch('os_cloud_config.keystone_pki.simplejson.load')
-    @mock.patch('os_cloud_config.keystone_pki.simplejson.dump')
+    @mock.patch('os_cloud_config.keystone_pki.json.load')
+    @mock.patch('os_cloud_config.keystone_pki.json.dump')
     def test_generate_certs_into_json_with_existing_certs(
         self, mock_json_dump, mock_json_load, open_, create_signing,
         create_ca, isfile):
diff --git a/requirements.txt b/requirements.txt
index a91de88..aa266a3 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -7,4 +7,3 @@ python-keystoneclient>=0.9.0
 python-novaclient>=2.17.0
 oslo.config>=1.2.1
 pyOpenSSL>=0.11
-simplejson>=2.0.9