openstack/deb-python-oslo.messaging
Code Issues Proposed changes

Fix transport URL parsing bug

Browse Source 
Handle e.g. foo://u:p@/bar. Right now we get:

 IndexError: string index out of range

from:

     if hostname[0] == '[':

Change-Id: I0bccebb14ad1d37862955e8988d160240bd1cf6d
This commit is contained in:
Mark McLoughlin
2013-08-18 01:44:37 +01:00
parent c79bd1f24c
commit 2564795108
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
oslo/messaging/transport.py
View File

@@ -386,7 +386,9 @@ class TransportURL(object):
if ':' in username: if ':' in username:
username, password = username.split(':', 1) username, password = username.split(':', 1)
if hostname[0] == '[': if not hostname:
hostname = None
elif hostname.startswith('['):
# Find the closing ']' and extract the hostname # Find the closing ']' and extract the hostname
host_end = hostname.find(']') host_end = hostname.find(']')
if host_end < 0: if host_end < 0:

7
tests/test_urls.py
View File

@@ -78,6 +78,13 @@ class TestParseURL(test_utils.BaseTestCase):
dict(host='host', port=1234, dict(host='host', port=1234,
username='u', password='p'), username='u', password='p'),
]))), ]))),
('creds_no_host',
dict(url='foo://u:p@/bar',
expect=dict(transport='foo',
virtual_host='bar',
hosts=[
dict(username='u', password='p'),
]))),
('multi_host', ('multi_host',
dict(url='foo://u:p@host1:1234,host2:4321/bar', dict(url='foo://u:p@host1:1234,host2:4321/bar',
expect=dict(transport='foo', expect=dict(transport='foo',