FIx CPU time consuming in green_poller poll()
The current implementation of GreenPoller.poll() calls eventlet.sleep() in `while True:` loop. It causes high CPU load, so should be refactored to use queue.get() with timeout. Change-Id: I48f1d8db39c4d7df8bd7f0bc9898ebefcd8df9e8
This commit is contained in:
@@ -16,9 +16,7 @@ import logging
|
|||||||
import threading
|
import threading
|
||||||
|
|
||||||
import eventlet
|
import eventlet
|
||||||
import six
|
|
||||||
|
|
||||||
from oslo_messaging._drivers import common as rpc_common
|
|
||||||
from oslo_messaging._drivers.zmq_driver import zmq_poller
|
from oslo_messaging._drivers.zmq_driver import zmq_poller
|
||||||
|
|
||||||
LOG = logging.getLogger(__name__)
|
LOG = logging.getLogger(__name__)
|
||||||
@@ -27,7 +25,7 @@ LOG = logging.getLogger(__name__)
|
|||||||
class GreenPoller(zmq_poller.ZmqPoller):
|
class GreenPoller(zmq_poller.ZmqPoller):
|
||||||
|
|
||||||
def __init__(self):
|
def __init__(self):
|
||||||
self.incoming_queue = six.moves.queue.Queue()
|
self.incoming_queue = eventlet.queue.LightQueue()
|
||||||
self.green_pool = eventlet.GreenPool()
|
self.green_pool = eventlet.GreenPool()
|
||||||
self.thread_by_socket = {}
|
self.thread_by_socket = {}
|
||||||
|
|
||||||
@@ -46,17 +44,10 @@ class GreenPoller(zmq_poller.ZmqPoller):
|
|||||||
eventlet.sleep()
|
eventlet.sleep()
|
||||||
|
|
||||||
def poll(self, timeout=None):
|
def poll(self, timeout=None):
|
||||||
incoming = None
|
|
||||||
try:
|
try:
|
||||||
with eventlet.Timeout(timeout, exception=rpc_common.Timeout):
|
return self.incoming_queue.get(timeout=timeout)
|
||||||
while incoming is None:
|
except eventlet.queue.Empty:
|
||||||
try:
|
return (None, None)
|
||||||
incoming = self.incoming_queue.get_nowait()
|
|
||||||
except six.moves.queue.Empty:
|
|
||||||
eventlet.sleep()
|
|
||||||
except rpc_common.Timeout:
|
|
||||||
return None, None
|
|
||||||
return incoming[0], incoming[1]
|
|
||||||
|
|
||||||
def close(self):
|
def close(self):
|
||||||
for thread in self.thread_by_socket.values():
|
for thread in self.thread_by_socket.values():
|
||||||
|
|||||||
Reference in New Issue
Block a user