5af4478fb2
This makes the RPC version support three elements, adding a "revision" in addition to the major and minor version. The revision would always be zero for the master branch of a service, but could be incremented for stable versions. This provides us some room to backport fixes that affect RPC versions in such a way that would avoid breaking the version lineage for systems running stable versions that may some day be involved in a rolling upgrade to a version from master. I didn't find any tests for version_is_compatible(), so I added some for existing version scenarios, as well as new ones with revisions. They also serve to validate that this doesn't break anything for code using two-element versions (the expectation is that two-element versions will still be used everywhere until a third is needed). Porting chages from Change-Id I239c17a3e305f572493498c4b96ee3c7514c5881 to oslo-incubator Change-Id: I4fa7b0be14a7afba36136a746b76036355f119b2
42 lines
1.4 KiB
Python
42 lines
1.4 KiB
Python
|
|
# Copyright 2013 Red Hat, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
|
|
def version_is_compatible(imp_version, version):
|
|
"""Determine whether versions are compatible.
|
|
|
|
:param imp_version: The version implemented
|
|
:param version: The version requested by an incoming message.
|
|
"""
|
|
version_parts = version.split('.')
|
|
imp_version_parts = imp_version.split('.')
|
|
try:
|
|
rev = version_parts[2]
|
|
except IndexError:
|
|
rev = 0
|
|
try:
|
|
imp_rev = imp_version_parts[2]
|
|
except IndexError:
|
|
imp_rev = 0
|
|
|
|
if int(version_parts[0]) != int(imp_version_parts[0]): # Major
|
|
return False
|
|
if int(version_parts[1]) > int(imp_version_parts[1]): # Minor
|
|
return False
|
|
if (int(version_parts[1]) == int(imp_version_parts[1]) and
|
|
int(rev) > int(imp_rev)): # Revision
|
|
return False
|
|
return True
|