openstack/deb-python-pygit2
Code Issues Proposed changes

Use realpath instead of abspath to properly handle symlinked temp dirs

Browse Source 
Fixes issue #47
This commit is contained in:
Josh Bleecher Snyder
2011-08-31 15:51:42 -07:00
parent 05058d8167
commit 0b23ea3fea
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/test_repository.py
View File

@@ -32,7 +32,7 @@ from __future__ import unicode_literals
import binascii import binascii
import unittest import unittest
import os import os
from os.path import join, abspath from os.path import join, realpath
from pygit2 import (GitError, GIT_OBJ_ANY, GIT_OBJ_BLOB, GIT_OBJ_COMMIT, from pygit2 import (GitError, GIT_OBJ_ANY, GIT_OBJ_BLOB, GIT_OBJ_COMMIT,
init_repository) init_repository)
@@ -91,8 +91,8 @@ class RepositoryTest(utils.BareRepoTestCase):
commit.message) commit.message)
def test_get_path(self): def test_get_path(self):
directory = abspath(self.repo.path) directory = realpath(self.repo.path)
expected = abspath(join(self._temp_dir, 'testrepo.git')) expected = realpath(join(self._temp_dir, 'testrepo.git'))
self.assertEqual(directory, expected) self.assertEqual(directory, expected)
def test_get_workdir(self): def test_get_workdir(self):
@@ -103,13 +103,13 @@ class RepositoryTest(utils.BareRepoTestCase):
class RepositoryTest_II(utils.RepoTestCase): class RepositoryTest_II(utils.RepoTestCase):
def test_get_path(self): def test_get_path(self):
directory = abspath(self.repo.path) directory = realpath(self.repo.path)
expected = abspath(join(self._temp_dir, 'testrepo', '.git')) expected = realpath(join(self._temp_dir, 'testrepo', '.git'))
self.assertEqual(directory, expected) self.assertEqual(directory, expected)
def test_get_workdir(self): def test_get_workdir(self):
directory = abspath(self.repo.workdir) directory = realpath(self.repo.workdir)
expected = abspath(join(self._temp_dir, 'testrepo')) expected = realpath(join(self._temp_dir, 'testrepo'))
self.assertEqual(directory, expected) self.assertEqual(directory, expected)