openstack/deb-python-pygit2
Code Issues Proposed changes

diff: make sure malloc succeeds

Browse Source
This commit is contained in:
Carlos Martín Nieto
2012-08-15 20:13:32 +02:00
parent 11d0c9a30f
commit 1138949a69
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/pygit2/diff.c
View File

@@ -114,6 +114,11 @@ static int diff_hunk_cb(
if (delta->old_file.path != NULL) { if (delta->old_file.path != NULL) {
len = strlen(delta->old_file.path) + 1; len = strlen(delta->old_file.path) + 1;
old_path = malloc(sizeof(char) * len); old_path = malloc(sizeof(char) * len);
if (old_path == NULL) {
free(hunk->header);
return -1;
}
memcpy(old_path, delta->old_file.path, len); memcpy(old_path, delta->old_file.path, len);
hunk->old_file = old_path; hunk->old_file = old_path;
} else { } else {
@@ -123,6 +128,12 @@ static int diff_hunk_cb(
if (delta->new_file.path != NULL) { if (delta->new_file.path != NULL) {
len = strlen(delta->new_file.path) + 1; len = strlen(delta->new_file.path) + 1;
new_path = malloc(sizeof(char) * len); new_path = malloc(sizeof(char) * len);
if (new_path == NULL) {
free(hunk->header);
free(old_path);
return -1;
}
memcpy(new_path, delta->new_file.path, len); memcpy(new_path, delta->new_file.path, len);
hunk->new_file = new_path; hunk->new_file = new_path;
} else { } else {