openstack/deb-python-pygit2
Code Issues Proposed changes

Add _name attribute to TreeEntry

Browse Source 
This mirrors the _message attribute for Tag, which gives you the raw
bytes from the entry name. Useful to parse repos where some filenames
aren't encoded as utf-8, such as https://github.com/wuts/earthquake.
This commit is contained in:
Nicolas Dandrimont
2015-09-28 18:24:48 +02:00
parent 681c7d4341
commit 2b083a1509
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/tree.c
View File

@@ -67,6 +67,15 @@ TreeEntry_name__get__(TreeEntry *self)
} }
PyDoc_STRVAR(TreeEntry__name__doc__, "Name (bytes).");
PyObject *
TreeEntry__name__get__(TreeEntry *self)
{
return PyBytes_FromString(git_tree_entry_name(self->entry));
}
PyDoc_STRVAR(TreeEntry_type__doc__, "Type."); PyDoc_STRVAR(TreeEntry_type__doc__, "Type.");
PyObject * PyObject *
@@ -177,6 +186,7 @@ TreeEntry_repr(TreeEntry *self)
PyGetSetDef TreeEntry_getseters[] = { PyGetSetDef TreeEntry_getseters[] = {
GETTER(TreeEntry, filemode), GETTER(TreeEntry, filemode),
GETTER(TreeEntry, name), GETTER(TreeEntry, name),
GETTER(TreeEntry, _name),
GETTER(TreeEntry, oid), GETTER(TreeEntry, oid),
GETTER(TreeEntry, id), GETTER(TreeEntry, id),
GETTER(TreeEntry, hex), GETTER(TreeEntry, hex),

1
test/test_tree.py
View File

@@ -45,6 +45,7 @@ class TreeTest(utils.BareRepoTestCase):
def assertTreeEntryEqual(self, entry, sha, name, filemode): def assertTreeEntryEqual(self, entry, sha, name, filemode):
self.assertEqual(entry.hex, sha) self.assertEqual(entry.hex, sha)
self.assertEqual(entry.name, name) self.assertEqual(entry.name, name)
self.assertEqual(entry._name, name.encode('utf-8'))
self.assertEqual(entry.filemode, filemode, self.assertEqual(entry.filemode, filemode,
'0%o != 0%o' % (entry.filemode, filemode)) '0%o != 0%o' % (entry.filemode, filemode))