openstack/deb-python-pygit2
Code Issues Proposed changes

Removed reduntant returns, fixs PEP7

Browse Source
This commit is contained in:
Jose Plana
2013-11-26 00:12:33 +01:00
parent 41bedc05f0
commit 37ed244a40
1 changed files with 12 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/remote.c
View File

@@ -124,10 +124,8 @@ Remote_fetch_refspecs__get__(Remote *self)
err = git_remote_get_fetch_refspecs(&refspecs, self->remote); err = git_remote_get_fetch_refspecs(&refspecs, self->remote);
if (err != 0) { if (err != 0)
Error_set(err); return Error_set(err);
return NULL;
}
new_list = get_pylist_from_git_strarray(&refspecs); new_list = get_pylist_from_git_strarray(&refspecs);
@@ -148,10 +146,8 @@ Remote_push_refspecs__get__(Remote *self)
err = git_remote_get_push_refspecs(&refspecs, self->remote); err = git_remote_get_push_refspecs(&refspecs, self->remote);
if (err != 0) { if (err != 0)
Error_set(err); return Error_set(err);
return NULL;
}
new_list = get_pylist_from_git_strarray(&refspecs); new_list = get_pylist_from_git_strarray(&refspecs);
git_strarray_free(&refspecs); git_strarray_free(&refspecs);
@@ -169,7 +165,7 @@ get_strarraygit_from_pylist(git_strarray *array, PyObject *pylist)
if (n < 0) if (n < 0)
return -1; return -1;
// allocate new git_strarray /* allocate new git_strarray */
void *ptr = calloc(n, sizeof(char *)); void *ptr = calloc(n, sizeof(char *));
if (!ptr) if (!ptr)
@@ -201,16 +197,13 @@ Remote_set_fetch_refspecs(Remote *self, PyObject *args)
if (! PyArg_Parse(args, "O", &pyrefspecs)) if (! PyArg_Parse(args, "O", &pyrefspecs))
return NULL; return NULL;
if (get_strarraygit_from_pylist(&fetch_refspecs , pyrefspecs) != 0) { if (get_strarraygit_from_pylist(&fetch_refspecs , pyrefspecs) != 0)
return NULL; return NULL;
}
err = git_remote_set_fetch_refspecs(self->remote, &fetch_refspecs); err = git_remote_set_fetch_refspecs(self->remote, &fetch_refspecs);
if (err != 0) { if (err != 0)
Error_set(err); return Error_set(err);
return NULL;
}
git_strarray_free(&fetch_refspecs); git_strarray_free(&fetch_refspecs);
@@ -234,16 +227,14 @@ Remote_set_push_refspecs(Remote *self, PyObject *args)
if (! PyArg_Parse(args, "O", &pyrefspecs)) if (! PyArg_Parse(args, "O", &pyrefspecs))
return NULL; return NULL;
if (get_strarraygit_from_pylist(&push_refspecs, pyrefspecs) != 0) { if (get_strarraygit_from_pylist(&push_refspecs, pyrefspecs) != 0)
return NULL; return NULL;
}
err = git_remote_set_push_refspecs(self->remote, &push_refspecs); err = git_remote_set_push_refspecs(self->remote, &push_refspecs);
if (err != 0) { if (err != 0)
Error_set(err); return Error_set(err);
return NULL;
}
git_strarray_free(&push_refspecs); git_strarray_free(&push_refspecs);