From 3ad89b3f624f140f03b99aef6baf6ef97bde1571 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=2E=20David=20Ib=C3=A1=C3=B1ez?= <jdavid.ibp@gmail.com>
Date: Fri, 1 Nov 2013 10:33:53 +0100
Subject: [PATCH] Rename Blob.binary to Blob.is_binary for consistency
---
src/blob.c | 6 +++---
test/test_blob.py | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/blob.c b/src/blob.c
index 1d41a22..83c7ece 100644
--- a/src/blob.c
+++ b/src/blob.c
@@ -41,10 +41,10 @@ Blob_size__get__(Blob *self)
}
-PyDoc_STRVAR(Blob_binary__doc__, "Binary.");
+PyDoc_STRVAR(Blob_is_binary__doc__, "True if binary data, False if not.");
PyObject *
-Blob_binary__get__(Blob *self)
+Blob_is_binary__get__(Blob *self)
{
if (git_blob_is_binary(self->blob))
Py_RETURN_TRUE;
@@ -58,7 +58,7 @@ PyDoc_STRVAR(Blob_data__doc__,
PyGetSetDef Blob_getseters[] = {
GETTER(Blob, size),
- GETTER(Blob, binary),
+ GETTER(Blob, is_binary),
{"data", (getter)Object_read_raw, NULL, Blob_data__doc__, NULL},
{NULL}
};
diff --git a/test/test_blob.py b/test/test_blob.py
index d1a6897..4e7a6cd 100644
--- a/test/test_blob.py
+++ b/test/test_blob.py
@@ -53,7 +53,7 @@ class BlobTest(utils.RepoTestCase):
sha = blob.oid.hex
self.assertEqual(sha, BLOB_SHA)
self.assertTrue(isinstance(blob, pygit2.Blob))
- self.assertFalse(blob.binary)
+ self.assertFalse(blob.is_binary)
self.assertEqual(pygit2.GIT_OBJ_BLOB, blob.type)
self.assertEqual(BLOB_CONTENT, blob.data)
self.assertEqual(len(BLOB_CONTENT), blob.size)