openstack/deb-python-pygit2
Code Issues Proposed changes

return NULL over -1

Browse Source
This commit is contained in:
richo
2013-01-05 11:39:53 +11:00
parent 6f6e1c2556
commit 4b42efbc8a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pygit2/repository.c
View File

@@ -182,16 +182,16 @@ Repository_as_iter(Repository *self)
err = git_repository_odb(&odb, self->repo); err = git_repository_odb(&odb, self->repo);
if (err < 0) { if (err < 0) {
Error_set(err); Error_set(err);
return -1; return NULL;
} }
err = git_odb_foreach(odb, Repository_build_as_iter, (void*)accum); err = git_odb_foreach(odb, Repository_build_as_iter, (void*)accum);
if (err == GIT_EUSER) { if (err == GIT_EUSER) {
git_odb_free(odb); git_odb_free(odb);
return -1; return NULL;
} else if (err < 0) { } else if (err < 0) {
git_odb_free(odb); git_odb_free(odb);
Error_set(err); Error_set(err);
return -1; return NULL;
} }
git_odb_free(odb); git_odb_free(odb);