openstack/deb-python-pygit2
Code Issues Proposed changes

Fix use-after-free when patch outlives diff

Browse Source
This commit is contained in:
Greg Fitzgerald
2014-12-18 01:45:35 +00:00
parent ceb40ecc52
commit 4f88840e93
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/diff.c
View File

@@ -77,8 +77,8 @@ wrap_patch(git_patch *patch)
delta = git_patch_get_delta(patch); delta = git_patch_get_delta(patch);
py_patch->old_file_path = delta->old_file.path; py_patch->old_file_path = strdup(delta->old_file.path);
py_patch->new_file_path = delta->new_file.path; py_patch->new_file_path = strdup(delta->new_file.path);
py_patch->status = git_diff_status_char(delta->status); py_patch->status = git_diff_status_char(delta->status);
py_patch->similarity = delta->similarity; py_patch->similarity = delta->similarity;
py_patch->flags = delta->flags; py_patch->flags = delta->flags;
@@ -153,8 +153,8 @@ Patch_dealloc(Patch *self)
Py_CLEAR(self->hunks); Py_CLEAR(self->hunks);
Py_CLEAR(self->old_id); Py_CLEAR(self->old_id);
Py_CLEAR(self->new_id); Py_CLEAR(self->new_id);
/* We do not have to free old_file_path and new_file_path, they will free(self->old_file_path);
* be freed by git_diff_list_free in Diff_dealloc */ free(self->new_file_path);
PyObject_Del(self); PyObject_Del(self);
} }