openstack/deb-python-pygit2
Code Issues Proposed changes

config: update Config_get_multivar_fn_wrapper to use git_config_entry *.

Browse Source 
This fixes:

  $ python setup.py build_ext --inplace
  ...
  src/pygit2/config.c: In function ‘Config_get_multivar’:
  src/pygit2/config.c:311:13: warning: passing argument 4 of ‘git_config_get_multivar’ from incompatible pointer type
  ../libgit2/include/git2/config.h:339:17: note: expected ‘int (*)(const struct git_config_entry *, void *)’ but argument is of type ‘int (*)(const char *, void *)’
  error: command 'i686-pc-linux-gnu-gcc' failed with exit status 1

reported by wolftankk in issue #140.

Signed-off-by: W. Trevor King <wking@tremily.us>
This commit is contained in:
W. Trevor King 2012-10-25 10:17:32 -04:00
parent 87572b2c8c
commit 53cd040bad
1 changed files with 2 additions and 2 deletions

4
src/pygit2/config.c

@ -283,12 +283,12 @@ Config_add_file(Config *self, PyObject *args)
}
int
Config_get_multivar_fn_wrapper(const char *value, void *data)
Config_get_multivar_fn_wrapper(const git_config_entry *value, void *data)
{
PyObject *list = (PyObject *)data;
PyObject *item = NULL;
if (!(item = PyUnicode_FromString(value)))
if (!(item = PyUnicode_FromString(value->value)))
return -2;
PyList_Append(list, item);