From 63d319895c9401b24678f05d3d022b1279548f54 Mon Sep 17 00:00:00 2001 From: richo Date: Fri, 4 Jan 2013 23:03:03 +1100 Subject: [PATCH] Don't leave dangling references to oid strings --- src/pygit2/repository.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pygit2/repository.c b/src/pygit2/repository.c index 63fc5de..bc0a2b8 100644 --- a/src/pygit2/repository.c +++ b/src/pygit2/repository.c @@ -165,12 +165,14 @@ static int Repository_build_as_iter(git_oid *oid, PyObject *accum) { int err; + PyObject *oid_str = git_oid_to_py_str(oid); - err = PyList_Append(accum, git_oid_to_py_str(oid)); + err = PyList_Append(accum, oid_str); if (err < 0) { Error_set(err); return -1; } + Py_XDECREF(oid_str); return 0; }