openstack/deb-python-pygit2
Code Issues Proposed changes

Support updating reference in create_commit

Browse Source
This commit is contained in:
J. David Ibáñez 2011-04-11 19:23:48 +02:00
parent 6f2b864619
commit 713b14d2ee
2 changed files with 7 additions and 6 deletions

10
pygit2.c

@ -416,7 +416,7 @@ free_parents(git_oid **parents, int n) {
static PyObject * static PyObject *
Repository_create_commit(Repository *self, PyObject *args) { Repository_create_commit(Repository *self, PyObject *args) {
git_signature *author, *committer; git_signature *author, *committer;
char *message; char *message, *update_ref;
git_oid tree_oid, oid; git_oid tree_oid, oid;
PyObject *py_parents, *py_parent; PyObject *py_parents, *py_parent;
int parent_count; int parent_count;
@ -424,7 +424,8 @@ Repository_create_commit(Repository *self, PyObject *args) {
int err, i; int err, i;
char hex[GIT_OID_HEXSZ]; char hex[GIT_OID_HEXSZ];
if (!PyArg_ParseTuple(args, "O&O&sO&O!", if (!PyArg_ParseTuple(args, "zO&O&sO&O!",
&update_ref,
signature_converter, &author, signature_converter, &author,
signature_converter, &committer, signature_converter, &committer,
&message, &message,
@ -449,9 +450,8 @@ Repository_create_commit(Repository *self, PyObject *args) {
return free_parents(parents, i); return free_parents(parents, i);
} }
err = git_commit_create(&oid, self->repo, NULL, err = git_commit_create(&oid, self->repo, update_ref, author, committer,
author, committer, message, &tree_oid, message, &tree_oid, parent_count, (const git_oid**)parents);
parent_count, (const git_oid**)parents);
free_parents(parents, parent_count); free_parents(parents, parent_count);
if (err < 0) if (err < 0)
return Error_set(err); return Error_set(err);

3
test/test_commit.py

@ -69,7 +69,8 @@ class CommitTest(utils.BareRepoTestCase):
tree = '967fce8df97cc71722d3c2a5930ef3e6f1d27b12' tree = '967fce8df97cc71722d3c2a5930ef3e6f1d27b12'
parents = [COMMIT_SHA] parents = [COMMIT_SHA]
sha = repo.create_commit(author, committer, message, tree, parents) sha = repo.create_commit(None, author, committer, message, tree,
parents)
commit = repo[sha] commit = repo[sha]
self.assertEqual(GIT_OBJ_COMMIT, commit.type) self.assertEqual(GIT_OBJ_COMMIT, commit.type)