openstack/deb-python-pygit2
Code Issues Proposed changes

Change Signature default encoding to UTF-8

Browse Source 
Fixes #581
This commit is contained in:
J. David Ibáñez
2015-11-15 19:31:08 +01:00
parent 91bb93d266
commit 7a8474cd44
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/signature.c
View File

@@ -38,7 +38,7 @@ Signature_init(Signature *self, PyObject *args, PyObject *kwds)
{ {
char *keywords[] = {"name", "email", "time", "offset", "encoding", NULL}; char *keywords[] = {"name", "email", "time", "offset", "encoding", NULL};
PyObject *py_name, *tname; PyObject *py_name, *tname;
char *email, *encoding = "ascii"; char *email, *encoding = "utf-8";
const char *name; const char *name;
long long time = -1; long long time = -1;
int offset = 0; int offset = 0;

6
test/test_signature.py
View File

@@ -38,9 +38,9 @@ class SignatureTest(NoRepoTestCase):
def test_default(self): def test_default(self):
signature = Signature( signature = Signature(
'Foo', 'foo@example.com', 1322174594, 60) 'Foo Ibáñez', 'foo@example.com', 1322174594, 60)
encoding = signature._encoding encoding = signature._encoding
self.assertEqual(encoding, 'ascii') self.assertEqual(encoding, 'utf-8')
self.assertEqual(signature.name, signature.raw_name.decode(encoding)) self.assertEqual(signature.name, signature.raw_name.decode(encoding))
self.assertEqual(signature.name.encode(encoding), signature.raw_name) self.assertEqual(signature.name.encode(encoding), signature.raw_name)
self.assertEqual(signature.email, self.assertEqual(signature.email,
@@ -50,7 +50,7 @@ class SignatureTest(NoRepoTestCase):
def test_ascii(self): def test_ascii(self):
self.assertRaises(UnicodeEncodeError, self.assertRaises(UnicodeEncodeError,
Signature, 'Foo Ibáñez', 'foo@example.com') Signature, 'Foo Ibáñez', 'foo@example.com', encoding='ascii')
def test_latin1(self): def test_latin1(self):
encoding = 'iso-8859-1' encoding = 'iso-8859-1'