openstack/deb-python-pygit2
Code Issues Proposed changes

remote: borrow the C string where possible

Browse Source
This commit is contained in:
Carlos Martín Nieto 2014-02-04 12:43:54 +01:00
parent 659749510f
commit 824ac672c1
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/remote.c
View File

@ -226,12 +226,13 @@ int
Remote_name__set__(Remote *self, PyObject* py_name) Remote_name__set__(Remote *self, PyObject* py_name)
{ {
int err; int err;
char* name; const char* name;
PyObject *tname;
name = py_str_to_c_str(py_name, NULL); name = py_str_borrow_c_str(&tname, py_name, NULL);
if (name != NULL) { if (name != NULL) {
err = git_remote_rename(self->remote, name, NULL, NULL); err = git_remote_rename(self->remote, name, NULL, NULL);
free(name); Py_DECREF(tname);
if (err == GIT_OK) if (err == GIT_OK)
return 0; return 0;
@ -404,12 +405,13 @@ int
Remote_url__set__(Remote *self, PyObject* py_url) Remote_url__set__(Remote *self, PyObject* py_url)
{ {
int err; int err;
char* url = NULL; const char* url = NULL;
PyObject *turl;
url = py_str_to_c_str(py_url, NULL); url = py_str_borrow_c_str(&turl, py_url, NULL);
if (url != NULL) { if (url != NULL) {
err = git_remote_set_url(self->remote, url); err = git_remote_set_url(self->remote, url);
free(url); Py_DECREF(turl);
if (err == GIT_OK) if (err == GIT_OK)
return 0; return 0;
@ -440,12 +442,13 @@ int
Remote_push_url__set__(Remote *self, PyObject* py_url) Remote_push_url__set__(Remote *self, PyObject* py_url)
{ {
int err; int err;
char* url = NULL; const char* url = NULL;
PyObject *turl;
url = py_str_to_c_str(py_url, NULL); url = py_str_borrow_c_str(&turl, py_url, NULL);
if (url != NULL) { if (url != NULL) {
err = git_remote_set_pushurl(self->remote, url); err = git_remote_set_pushurl(self->remote, url);
free(url); Py_DECREF(turl);
if (err == GIT_OK) if (err == GIT_OK)
return 0; return 0;