openstack/deb-python-pygit2
Code Issues Proposed changes

Check for error after call to py_str_to_c_str

Browse Source 
Fixes segfaults in 'Repository.create_commit' and 'Signature(...)'
Error reported by Han-Wen Nienhuys in the mailing list.
This commit is contained in:
J. David Ibáñez 2012-03-03 17:33:57 +01:00
parent c6ebc98930
commit 8380c625c4
1 changed files with 4 additions and 0 deletions

4
pygit2.c

@ -694,6 +694,8 @@ Repository_create_commit(Repository *self, PyObject *args)
goto out; goto out;
message = py_str_to_c_str(py_message, encoding); message = py_str_to_c_str(py_message, encoding);
if (message == NULL)
goto out;
err = git_tree_lookup_prefix(&tree, self->repo, &oid, (unsigned int)len); err = git_tree_lookup_prefix(&tree, self->repo, &oid, (unsigned int)len);
if (err < 0) { if (err < 0) {
@ -2811,6 +2813,8 @@ Signature_init(Signature *self, PyObject *args, PyObject *kwds)
return -1; return -1;
name = py_str_to_c_str(py_name, encoding); name = py_str_to_c_str(py_name, encoding);
if (name == NULL)
return -1;
err = git_signature_new(&signature, name, email, time, offset); err = git_signature_new(&signature, name, email, time, offset);
if (err < 0) { if (err < 0) {