Add the parents param to the Commit init method

And fix unit tests for the commit object.

pygit2.c

@@ -36,8 +36,8 @@ typedef struct {
     PyObject *index; /* It will be None for a bare repository */
 } Repository;
 
-/* The structs for some of the object subtypes are identical except for the type
+/* The structs for some of the object subtypes are identical except for the
- * of their object pointers. */
+ * type of their object pointers. */
 #define OBJECT_STRUCT(_name, _ptr_type, _ptr_name) \
         typedef struct {\
             PyObject_HEAD\
@@ -583,14 +583,27 @@ signature_converter(PyObject *value, git_signature **out) {
     return 1;
 }
 
+static int
+free_parents(git_oid **parents, int n) {
+    int i;
+
+    for (i = 0; i < n; i++)
+        free(parents[i]);
+    free(parents);
+    return -1;
+}
+
 static int
 Commit_init(Commit *py_commit, PyObject *args, PyObject *kwds) {
     Repository *repo = NULL;
     git_signature *author, *committer;
     char *message;
     git_oid tree_oid, oid;
+    PyObject *py_parents, *py_parent;
+    int parent_count;
+    git_oid **parents;
     git_commit *commit;
-    int err;
+    int err, i;
 
     if (kwds) {
         PyErr_Format(PyExc_TypeError, "%s takes no keyword arugments",
@@ -598,26 +611,45 @@ Commit_init(Commit *py_commit, PyObject *args, PyObject *kwds) {
         return -1;
     }
 
-    /* TODO Support parents */
+    if (!PyArg_ParseTuple(args, "O!O&O&sO&O!", &RepositoryType, &repo,
-    if (!PyArg_ParseTuple(args, "O!O&O&sO&", &RepositoryType, &repo,
                           signature_converter, &author,
                           signature_converter, &committer,
                           &message,
-                          py_str_to_git_oid, &tree_oid))
+                          py_str_to_git_oid, &tree_oid,
+                          &PyList_Type, &py_parents))
         return -1;
 
-    err = git_commit_create(&oid, repo->repo, NULL,
+    parent_count = (int)PyList_Size(py_parents);
-        author, committer, message, &tree_oid, 0, NULL);
+    parents = malloc(parent_count * sizeof(git_oid*));
-    if (err < 0)
+    if (parents == NULL) {
+        PyErr_SetNone(PyExc_MemoryError);
         return -1;
+    }
+    for (i = 0; i < parent_count; i++) {
+        parents[i] = malloc(sizeof(git_oid));
+        if (parents[i] == NULL) {
+            PyErr_SetNone(PyExc_MemoryError);
+            return free_parents(parents, i);
+        }
+        py_parent = PyList_GET_ITEM(py_parents, i);
+        if (!py_str_to_git_oid(py_parent, parents[i]))
+            return free_parents(parents, i);
+    }
+
+    err = git_commit_create(&oid, repo->repo, NULL,
+        author, committer, message, &tree_oid,
+        parent_count, (const git_oid**)parents);
+    if (err < 0)
+        return free_parents(parents, parent_count);
 
     err = git_commit_lookup(&commit, repo->repo, &oid);
     if (err < 0)
-        return -1;
+        return free_parents(parents, parent_count);
 
     Py_INCREF(repo);
     py_commit->repo = repo;
     py_commit->commit = commit;
+    free_parents(parents, parent_count);
     return 0;
 }
 

test/test_commit.py

@@ -31,7 +31,7 @@ __author__ = 'dborowitz@google.com (Dave Borowitz)'
 
 import unittest
 
-import pygit2
+from pygit2 import Commit, GIT_OBJ_COMMIT
 import utils
 
 COMMIT_SHA = '5fe808e8953c12735680c257f56600cb0de44b10'
@@ -64,24 +64,20 @@ class CommitTest(utils.BareRepoTestCase):
         message = 'New commit.\n\nMessage.\n'
         committer = ('John Doe', 'jdoe@example.com', 12346)
         author = ('Jane Doe', 'jdoe2@example.com', 12345)
+        tree = '967fce8df97cc71722d3c2a5930ef3e6f1d27b12'
 
-        commit = pygit2.Commit(self.repo)
+        parents = [COMMIT_SHA]
-        commit.message = message
+        commit = Commit(self.repo, author, committer, message, tree, parents)
-        commit.committer = committer
-        commit.author = author
 
-        self.assertEqual(0, len(commit.parents))
+        self.assertEqual(GIT_OBJ_COMMIT, commit.type)
-
+        self.assertEqual('30bb126a4959290987fc07ea49f92be276dce9d6',
-        commit.add_parent(COMMIT_SHA)
+                         commit.sha)
-
-        self.assertEqual(None, commit.sha)
-        self.assertEqual(pygit2.GIT_OBJ_COMMIT, commit.type)
         self.assertEqual(message, commit.message)
         self.assertEqual('New commit.', commit.message_short)
         self.assertEqual(12346, commit.commit_time)
         self.assertEqual(committer, commit.committer)
         self.assertEqual(author, commit.author)
-        self.assertEqual(None, commit.tree)
+        self.assertEqual(tree, commit.tree.sha)
         self.assertEqual(1, len(commit.parents))
         self.assertEqual(COMMIT_SHA, commit.parents[0].sha)
 
@@ -91,15 +87,12 @@ class CommitTest(utils.BareRepoTestCase):
         author = ('Jane Doe', 'jdoe2@example.com', 12345)
 
         commit = self.repo[COMMIT_SHA]
-        commit.message = message
+        self.assertRaises(AttributeError, setattr, commit, 'message', message)
-        commit.committer = committer
+        self.assertRaises(AttributeError, setattr, commit, 'committer',
-        commit.author = author
+                          committer)
-
+        self.assertRaises(AttributeError, setattr, commit, 'author', author)
-        self.assertEqual(message, commit.message)
+        self.assertRaises(AttributeError, setattr, commit, 'tree', None)
-        self.assertEqual('New commit.', commit.message_short)
+        self.assertRaises(AttributeError, setattr, commit, 'parents', None)
-        self.assertEqual(12346, commit.commit_time)
-        self.assertEqual(committer, commit.committer)
-        self.assertEqual(author, commit.author)
 
 
 if __name__ == '__main__':