openstack/deb-python-pygit2
Code Issues Proposed changes

Fix create_blob_fromiobase with pypy

Browse Source 
The file object is passed to us, so we never incremented
its refcount. We shouldn't decrement it on exit.
This commit is contained in:
Carlos Martín Nieto
2015-10-31 16:57:20 +01:00
parent 13f4ddec1d
commit 91bb93d266
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/repository.c
View File

@@ -881,7 +881,6 @@ Repository_create_blob_fromiobase(Repository *self, PyObject *py_file)
py_is_readable = PyObject_CallMethod(py_file, "readable", NULL); py_is_readable = PyObject_CallMethod(py_file, "readable", NULL);
if (!py_is_readable) { if (!py_is_readable) {
Py_DECREF(py_file);
if (PyErr_ExceptionMatches(PyExc_AttributeError)) if (PyErr_ExceptionMatches(PyExc_AttributeError))
PyErr_SetObject(PyExc_TypeError, py_file); PyErr_SetObject(PyExc_TypeError, py_file);
return NULL; return NULL;
@@ -898,8 +897,6 @@ Repository_create_blob_fromiobase(Repository *self, PyObject *py_file)
err = git_blob_create_fromchunks(&oid, self->repo, NULL, &read_chunk, err = git_blob_create_fromchunks(&oid, self->repo, NULL, &read_chunk,
py_file); py_file);
Py_DECREF(py_file);
if (err < 0) if (err < 0)
return Error_set(err); return Error_set(err);