From 9ec56c07ea46067cba9185443ec21962921bdb81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=2E=20David=20Ib=C3=A1=C3=B1ez?= Date: Sat, 5 Jan 2013 10:36:09 +0100 Subject: [PATCH] Make Repostirory_as_iter shorter Error_set already returns NULL --- src/pygit2/repository.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/pygit2/repository.c b/src/pygit2/repository.c index daa2c44..4dc7c34 100644 --- a/src/pygit2/repository.c +++ b/src/pygit2/repository.c @@ -180,21 +180,17 @@ Repository_as_iter(Repository *self) PyObject *accum = PyList_New(0); err = git_repository_odb(&odb, self->repo); - if (err < 0) { - Error_set(err); - return NULL; - } + if (err < 0) + return Error_set(err); + err = git_odb_foreach(odb, Repository_build_as_iter, (void*)accum); + git_odb_free(odb); if (err == GIT_EUSER) { - git_odb_free(odb); return NULL; } else if (err < 0) { - git_odb_free(odb); - Error_set(err); - return NULL; + return Error_set(err); } - git_odb_free(odb); return PyObject_GetIter(accum); }