openstack/deb-python-pygit2
Code Issues Proposed changes

Fixed memory leaks

Browse Source 
Repository_read would not free the odb object after using it.
Object_read_raw didn't close the odb object after usage
This commit is contained in:
Sebastian Thiel
2011-07-08 11:54:36 +02:00
parent cf37c15059
commit a0975f78d5
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pygit2.c
View File

@@ -238,14 +238,14 @@ py_str_to_git_oid(PyObject *py_str, git_oid *oid) {
Error_set_py_obj(GIT_ENOTOID, py_str); Error_set_py_obj(GIT_ENOTOID, py_str);
return 0; return 0;
} }
if (PyString_Size(py_str) == 20) { if (PyString_Size(py_str) == 20) {
git_oid_fromraw(oid, (const unsigned char*)hex_or_bin); git_oid_fromraw(oid, (const unsigned char*)hex_or_bin);
err = 0; err = 0;
} else { } else {
err = git_oid_fromstr(oid, hex_or_bin); err = git_oid_fromstr(oid, hex_or_bin);
} }
if (err < 0) { if (err < 0) {
Error_set_py_obj(err, py_str); Error_set_py_obj(err, py_str);
return 0; return 0;
@@ -324,11 +324,14 @@ Repository_read(Repository *self, PyObject *py_hex) {
if (err < 0) if (err < 0)
return Error_set_py_obj(err, py_hex); return Error_set_py_obj(err, py_hex);
return Py_BuildValue( PyObject* tuple = Py_BuildValue(
"(ns#)", "(ns#)",
git_odb_object_type(obj), git_odb_object_type(obj),
git_odb_object_data(obj), git_odb_object_data(obj),
git_odb_object_size(obj)); git_odb_object_size(obj));
git_odb_object_close(obj);
return tuple;
} }
static PyObject * static PyObject *
@@ -797,6 +800,8 @@ Object_read_raw(Object *self) {
git_odb_object_data(obj), git_odb_object_data(obj),
git_odb_object_size(obj)); git_odb_object_size(obj));
git_odb_object_close(obj);
cleanup: cleanup:
Py_XDECREF(py_sha); Py_XDECREF(py_sha);
return result; return result;