openstack/deb-python-pygit2
Code Issues Proposed changes

removed redundant repo entry in DiffObject

Browse Source
This commit is contained in:
Nico von Geyso 2012-05-24 19:17:35 +02:00
parent 2a49eadc57
commit aec936c94e
1 changed files with 4 additions and 8 deletions

12
pygit2.c

@ -114,7 +114,6 @@ OBJECT_STRUCT(Walker, git_revwalk, walk)
typedef struct { typedef struct {
PyObject_HEAD PyObject_HEAD
Repository *repo;
Tree *t0; Tree *t0;
Tree *t1; Tree *t1;
} Diff; } Diff;
@ -1756,7 +1755,7 @@ static int diff_hunk_cb(
const char *header, const char *header,
size_t header_len) size_t header_len)
{ {
PyObject *hunks, *entry; PyObject *hunks;
Hunk *hunk; Hunk *hunk;
hunks = PyDict_GetItemString(cb_data, "hunks"); hunks = PyDict_GetItemString(cb_data, "hunks");
@ -1814,7 +1813,7 @@ Diff_changes(Diff *self)
int err; int err;
err = git_diff_tree_to_tree( err = git_diff_tree_to_tree(
self->repo->repo, self->t0->repo->repo,
&opts, &opts,
self->t0->tree, self->t0->tree,
self->t1->tree, self->t1->tree,
@ -1863,7 +1862,7 @@ Diff_patch(Diff *self)
int err; int err;
err = git_diff_tree_to_tree( err = git_diff_tree_to_tree(
self->repo->repo, self->t0->repo->repo,
&opts, &opts,
self->t0->tree, self->t0->tree,
self->t1->tree, self->t1->tree,
@ -1876,7 +1875,7 @@ Diff_patch(Diff *self)
PyObject *patch = PyBytes_FromString(""); PyObject *patch = PyBytes_FromString("");
git_diff_print_patch(changes, &diff, &diff_print_cb); git_diff_print_patch(changes, &patch, &diff_print_cb);
return patch; return patch;
} }
@ -1968,7 +1967,6 @@ static PyTypeObject HunkType = {
static void static void
Diff_dealloc(Diff *self) Diff_dealloc(Diff *self)
{ {
Py_XDECREF(self->repo);
Py_XDECREF(self->t0); Py_XDECREF(self->t0);
Py_XDECREF(self->t1); Py_XDECREF(self->t1);
PyObject_Del(self); PyObject_Del(self);
@ -2036,11 +2034,9 @@ Tree_diff_tree(Tree *self, PyObject *args)
py_diff = PyObject_New(Diff, &DiffType); py_diff = PyObject_New(Diff, &DiffType);
if (py_diff) { if (py_diff) {
Py_INCREF(py_diff); Py_INCREF(py_diff);
Py_INCREF(self->repo);
Py_INCREF(py_tree); Py_INCREF(py_tree);
Py_INCREF(self); Py_INCREF(self);
py_diff->repo = self->repo;
py_diff->t0 = self; py_diff->t0 = self;
py_diff->t1 = py_tree; py_diff->t1 = py_tree;
} }