openstack/deb-python-pygit2
Code Issues Proposed changes

Make TreeEntry not to inherit from Object

Browse Source 
Tree entries are not Git objects like commits, blobs, etc.

By inheriting from Object it was even possible to produce a segfault
when accessing inherited attributes like 'type'.
This commit is contained in:
J. David Ibáñez
2011-02-23 19:01:57 +01:00
parent 7e8d2bb19d
commit b050de2b26
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pygit2.c
View File

@@ -1896,7 +1896,6 @@ initpygit2(void)
CommitType.tp_new = PyType_GenericNew; CommitType.tp_new = PyType_GenericNew;
if (PyType_Ready(&CommitType) < 0) if (PyType_Ready(&CommitType) < 0)
return; return;
TreeEntryType.tp_base = &ObjectType;
TreeEntryType.tp_new = PyType_GenericNew; TreeEntryType.tp_new = PyType_GenericNew;
if (PyType_Ready(&TreeEntryType) < 0) if (PyType_Ready(&TreeEntryType) < 0)
return; return;