openstack/deb-python-pygit2
Code Issues Proposed changes

Always decref the new string. Don't set err.

Browse Source
This commit is contained in:
richo
2013-01-05 02:20:40 +11:00
parent 63d319895c
commit badb7f435d
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/pygit2/repository.c
View File

@@ -168,12 +168,8 @@ Repository_build_as_iter(git_oid *oid, PyObject *accum)
PyObject *oid_str = git_oid_to_py_str(oid); PyObject *oid_str = git_oid_to_py_str(oid);
err = PyList_Append(accum, oid_str); err = PyList_Append(accum, oid_str);
if (err < 0) { Py_DECREF(oid_str);
Error_set(err); return err;
return -1;
}
Py_XDECREF(oid_str);
return 0;
} }
PyObject * PyObject *