openstack/deb-python-pygit2
Code Issues Proposed changes

py_str_to_git_oid: check length of raw oid (#205)

Browse Source
This commit is contained in:
J. David Ibáñez
2013-04-13 12:00:18 +02:00
parent 41bae9150d
commit c7785e591b
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/oid.c
View File

@@ -45,6 +45,10 @@ py_str_to_git_oid(PyObject *py_str, git_oid *oid)
err = PyBytes_AsStringAndSize(py_str, &hex_or_bin, &len); err = PyBytes_AsStringAndSize(py_str, &hex_or_bin, &len);
if (err) if (err)
return -1; return -1;
if (len > GIT_OID_RAWSZ) {
PyErr_SetObject(PyExc_ValueError, py_str);
return -1;
}
memcpy(oid->id, (const unsigned char*)hex_or_bin, len); memcpy(oid->id, (const unsigned char*)hex_or_bin, len);
return len * 2; return len * 2;
} }