openstack/deb-python-pygit2
Code Issues Proposed changes

Keep path references in merge_file_from_index

Browse Source 
IndexEntry._to_c requires its caller to hold a reference to the path it
returns until it no longer needs the C structure.
Repository.merge_file_from_index was not doing so, causing the merge
text to contain garbage from freed memory in some cases.
This commit is contained in:
Colin Watson
2015-04-23 04:29:13 +01:00
parent f923e20f2d
commit efb49f8418
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pygit2/repository.py
View File

@@ -551,9 +551,12 @@ class Repository(_Repository):
""" """
cmergeresult = ffi.new('git_merge_file_result *') cmergeresult = ffi.new('git_merge_file_result *')
cancestor = ancestor._to_c()[0] if ancestor is not None else ffi.NULL cancestor, ancestor_str_ref = (
cours = ours._to_c()[0] if ours is not None else ffi.NULL ancestor._to_c() if ancestor is not None else (ffi.NULL, ffi.NULL))
ctheirs = theirs._to_c()[0] if theirs is not None else ffi.NULL cours, ours_str_ref = (
ours._to_c() if ours is not None else (ffi.NULL, ffi.NULL))
ctheirs, theirs_str_ref = (
theirs._to_c() if theirs is not None else (ffi.NULL, ffi.NULL))
err = C.git_merge_file_from_index( err = C.git_merge_file_from_index(
cmergeresult, self._repo, cmergeresult, self._repo,