openstack/deb-python-pygit2
Code Issues Proposed changes

py_str_to_git_oid: don't decrease refcount too early

Browse Source 
Error handling still broken in py_str_to_git_oid, can be verified by
typing repo['toto']
This commit is contained in:
J. David Ibáñez
2011-09-04 00:28:55 +02:00
parent 7b3685aaea
commit f9b57d5eb9
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pygit2.c
View File

@@ -274,6 +274,7 @@ wrap_reference(git_reference * c_reference)
static int static int
py_str_to_git_oid(PyObject *py_str, git_oid *oid) py_str_to_git_oid(PyObject *py_str, git_oid *oid)
{ {
PyObject *py_hex;
const char *hex_or_bin; const char *hex_or_bin;
int err; int err;
@@ -288,11 +289,11 @@ py_str_to_git_oid(PyObject *py_str, git_oid *oid)
/* Case 2: hex sha */ /* Case 2: hex sha */
if (PyUnicode_Check(py_str)) { if (PyUnicode_Check(py_str)) {
py_str = PyUnicode_AsASCIIString(py_str); py_hex = PyUnicode_AsASCIIString(py_str);
if (py_str == NULL) if (py_hex == NULL)
return 0; return 0;
hex_or_bin = PyString_AsString(py_str); hex_or_bin = PyString_AsString(py_hex);
Py_DECREF(py_str); Py_DECREF(py_hex);
if (hex_or_bin == NULL) if (hex_or_bin == NULL)
return 0; return 0;
err = git_oid_fromstr(oid, hex_or_bin); err = git_oid_fromstr(oid, hex_or_bin);