From aae1577e3c06bb4885ff8d9a243b4e77662056f4 Mon Sep 17 00:00:00 2001 From: Peter Hamilton Date: Fri, 11 Nov 2016 14:40:46 -0500 Subject: [PATCH] Fixing potential undefined variable error in client open This change reorganizes some of the error handling code in the client open routine, preventing the generation of an undefined variable error. The net effect of the client open routine is unchanged. Fixes #199 --- kmip/services/kmip_client.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/kmip/services/kmip_client.py b/kmip/services/kmip_client.py index e1168a9..115bc22 100644 --- a/kmip/services/kmip_client.py +++ b/kmip/services/kmip_client.py @@ -210,6 +210,8 @@ class KMIPProxy(KMIP): self.logger.debug("KMIPProxy suppress_ragged_eofs: {0}".format( self.suppress_ragged_eofs)) + last_error = None + for host in self.host_list: self.host = host sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) @@ -221,11 +223,13 @@ class KMIPProxy(KMIP): self.logger.error("An error occurred while connecting to " "appliance " + self.host) self.socket.close() + last_error = e else: return self.socket = None - raise e + if last_error: + raise last_error def _create_socket(self, sock): self.socket = ssl.wrap_socket(