openstack/deb-python-pyngus
Code Issues Proposed changes

quiet a chatty debug log message

Browse Source 
move the socket read/write debug log message so it is only issued when
there is an unhandled socket error
This commit is contained in:
Kenneth Giusti
2017-02-27 13:52:22 -05:00
parent 5949700ec5
commit e4b2138e14
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pyngus/sockets.py
View File

@@ -50,7 +50,6 @@ def read_socket_input(connection, socket_obj):
LOG.debug("Socket timeout exception %s", str(e))
raise # caller must handle
except socket.error as e:
LOG.debug("Socket error exception %s", str(e))
err = e.errno
if err in [errno.EAGAIN,
errno.EWOULDBLOCK,
@@ -58,6 +57,7 @@ def read_socket_input(connection, socket_obj):
# try again later
return 0
# otherwise, unrecoverable, caller must handle
LOG.debug("Socket error exception %s", str(e))
raise
except Exception as e: # beats me... assume fatal
LOG.debug("unknown socket exception %s", str(e))
@@ -97,7 +97,6 @@ def write_socket_output(connection, socket_obj):
LOG.debug("Socket timeout exception %s", str(e))
raise # caller must handle
except socket.error as e:
LOG.debug("Socket error exception %s", str(e))
err = e.errno
if err in [errno.EAGAIN,
errno.EWOULDBLOCK,
@@ -105,6 +104,7 @@ def write_socket_output(connection, socket_obj):
# try again later
return 0
# else assume fatal let caller handle it:
LOG.debug("Socket error exception %s", str(e))
raise
except Exception as e: # beats me... assume fatal
LOG.debug("unknown socket exception %s", str(e))