From 6f0ff8644fd0d4325cd2268a98b500b0c2614332 Mon Sep 17 00:00:00 2001 From: Roland Hedberg Date: Mon, 15 Dec 2014 15:18:27 +0100 Subject: [PATCH] Better error message --- src/saml2/sigver.py | 2 +- tests/test_40_sigver.py | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/saml2/sigver.py b/src/saml2/sigver.py index 0ac1f03..5b83df4 100644 --- a/src/saml2/sigver.py +++ b/src/saml2/sigver.py @@ -856,7 +856,7 @@ class CryptoBackendXmlSec1(CryptoBackend): logger.error( "Signing operation failed :\nstdout : %s\nstderr : %s" % ( stdout, stderr)) - raise SigverError("Signing failed") + raise SigverError(stderr) except DecryptError: raise SigverError("Signing failed") diff --git a/tests/test_40_sigver.py b/tests/test_40_sigver.py index c0d1281..0eefeed 100644 --- a/tests/test_40_sigver.py +++ b/tests/test_40_sigver.py @@ -1,7 +1,8 @@ #!/usr/bin/env python import base64 -from saml2.sigver import pre_encryption_part, make_temp, XmlsecError +from saml2.sigver import pre_encryption_part, make_temp, XmlsecError, \ + SigverError from saml2.mdstore import MetadataStore from saml2.saml import assertion_from_string, EncryptedAssertion from saml2.samlp import response_from_string @@ -495,7 +496,7 @@ def test_xmlsec_err(): sec.sign_statement(assertion, class_name(assertion), key_file=full_path("tes.key"), node_id=assertion.id) - except XmlsecError as err: # should throw an exception + except (XmlsecError, SigverError) as err: # should throw an exception pass else: assert False @@ -506,4 +507,4 @@ if __name__ == "__main__": # t.setup_class() # t.test_non_verify_2() - test_xbox() + test_xmlsec_err()