openstack/deb-python-pysaml2
Code Issues Proposed changes

Raise an exception on wrong type

Browse Source
This commit is contained in:
Roland Hedberg
2010-10-12 08:53:14 +02:00
parent b9a39f1957
commit 770938fda6
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/saml2/sigver.py
View File

@@ -465,6 +465,8 @@ class SecurityContext(object):
request as a samlp.Request instance request as a samlp.Request instance
""" """
request = samlp.logout_request_from_string(decoded_xml) request = samlp.logout_request_from_string(decoded_xml)
if not request:
raise TypeError("Not a LogoutRequest")
if not request.signature: if not request.signature:
if must: if must:
@@ -485,6 +487,8 @@ class SecurityContext(object):
the response as a samlp.LogoutResponse instance the response as a samlp.LogoutResponse instance
""" """
response = samlp.logout_response_from_string(decoded_xml) response = samlp.logout_response_from_string(decoded_xml)
if not response:
raise TypeError("Not a LogoutResponse")
if not response.signature: if not response.signature:
if must: if must:
@@ -505,6 +509,8 @@ class SecurityContext(object):
request as a samlp.Request instance request as a samlp.Request instance
""" """
request = samlp.authn_request_from_string(decoded_xml) request = samlp.authn_request_from_string(decoded_xml)
if not request:
raise TypeError("Not an AuthnRequest")
if not request.signature: if not request.signature:
if must: if must:
@@ -525,6 +531,8 @@ class SecurityContext(object):
""" """
response = samlp.response_from_string(decoded_xml) response = samlp.response_from_string(decoded_xml)
if not response:
raise TypeError("Not a Response")
if response.signature: if response.signature:
self._check_signature(decoded_xml, response) self._check_signature(decoded_xml, response)