openstack/deb-python-pysaml2
Code Issues Proposed changes

Merge pull request #81 from novapost/specify_logout_expected_binding

Browse Source 
Add expected_binding parameter when 'do_logout'
This commit is contained in:
Roland Hedberg
2014-02-26 06:30:07 -08:00
parent b1ab60679c aa5d3c1ab9
commit 97c06938b7
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/saml2/client.py
View File

@@ -117,7 +117,8 @@ class Saml2Client(Base):
entity_ids = self.users.issuers_of_info(name_id) entity_ids = self.users.issuers_of_info(name_id)
return self.do_logout(name_id, entity_ids, reason, expire, sign) return self.do_logout(name_id, entity_ids, reason, expire, sign)
def do_logout(self, name_id, entity_ids, reason, expire, sign=None): def do_logout(self, name_id, entity_ids, reason, expire, sign=None,
expected_binding=None):
""" """
:param name_id: Identifier of the Subject (a NameID instance) :param name_id: Identifier of the Subject (a NameID instance)
@@ -126,6 +127,8 @@ class Saml2Client(Base):
:param reason: The reason for doing the logout :param reason: The reason for doing the logout
:param expire: Try to logout before this time. :param expire: Try to logout before this time.
:param sign: Whether to sign the request or not :param sign: Whether to sign the request or not
:param expected_binding: Specify the expected binding then not try it
all
:return: :return:
""" """
# check time # check time
@@ -142,6 +145,8 @@ class Saml2Client(Base):
# for all where I can use the SOAP binding, do those first # for all where I can use the SOAP binding, do those first
for binding in [BINDING_SOAP, BINDING_HTTP_POST, for binding in [BINDING_SOAP, BINDING_HTTP_POST,
BINDING_HTTP_REDIRECT]: BINDING_HTTP_REDIRECT]:
if expected_binding and binding != expected_binding:
continue
try: try:
srvs = self.metadata.single_logout_service(entity_id, srvs = self.metadata.single_logout_service(entity_id,
binding, binding,