openstack/deb-python-pysaml2
Code Issues Proposed changes

Change examples to bind to 127.0.0.1 by default.

Browse Source 
Since the README already says to point a browser at localhost, it
was surprising to see the listeners bound to 0.0.0.0 by default.
Changed that and added notes in README about how to change it if
the user really wants to make a test listener accessible
externally.

Updated output messages during startup to include the bound IP,
to make this more obvious.

Added a missing EOL or two.
This commit is contained in:
Hank Leininger
2014-04-02 22:00:28 -04:00
parent 104198416b
commit c8edb28d5b
6 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
example/README
View File

@@ -25,6 +25,10 @@ To run the setup do
and then use your favourite webbrowser to look at "http://localhost:8087/whoami"
Note, the listeners are all configured to bind to localhost (127.0.0.1) only.
If you want to be able to connect to them externally, grep "HOST = '127.0.0.1'"
example/*/*.py and replace 127.0.0.1 with 0.0.0.0 or a specific IP.
./all.sh stop
will of course stop your IdP and SP.

5
example/idp2/idp.py
View File

@@ -976,10 +976,11 @@ if __name__ == '__main__':
module_directory=_rot + 'modules',
input_encoding='utf-8', output_encoding='utf-8')
HOST = '127.0.0.1'
PORT = 8088
SRV = make_server('', PORT, application)
print "IdP listening on port: %s" % PORT
SRV = make_server(HOST, PORT, application)
print "IdP listening on %s:%s" % (HOST, PORT)
SRV.serve_forever()
else:
_rot = args.mako_root

5
example/idp2_repoze/idp.py
View File

@@ -977,10 +977,11 @@ if __name__ == '__main__':
module_directory=_rot + 'modules',
input_encoding='utf-8', output_encoding='utf-8')
HOST = '127.0.0.1'
PORT = 8088
SRV = make_server('', PORT, application)
print "IdP listening on port: %s" % PORT
SRV = make_server(HOST, PORT, application)
print "IdP listening on %s:%s" % (HOST, PORT)
SRV.serve_forever()
else:
_rot = args.mako_root

5
example/sp-repoze/sp.py
View File

@@ -268,6 +268,7 @@ app_with_auth = make_middleware_with_config(application, {"here": "."},
log_file="repoze_who.log")
# ----------------------------------------------------------------------------
HOST = '127.0.0.1'
PORT = 8087
# allow uwsgi or gunicorn mount
@@ -291,6 +292,6 @@ if __name__ == '__main__':
args = parser.parse_args()
from wsgiref.simple_server import make_server
srv = make_server('', PORT, app_with_auth)
print "SP listening on port: %s" % PORT
srv = make_server(HOST, PORT, app_with_auth)
print "SP listening on %s:%s" % (HOST, PORT)
srv.serve_forever()

1
example/sp-wsgi/service_conf.py
View File

@@ -1,5 +1,6 @@
from saml2.assertion import Policy
HOST = '127.0.0.1'
PORT = 8087
HTTPS = False

5
example/sp-wsgi/sp.py
View File

@@ -683,6 +683,7 @@ def application(environ, start_response):
# ----------------------------------------------------------------------------
HOST = service_conf.HOST
PORT = service_conf.PORT
# ------- HTTPS -------
# These should point to relevant files
@@ -727,13 +728,13 @@ if __name__ == '__main__':
add_urls()
SRV = wsgiserver.CherryPyWSGIServer(('0.0.0.0', PORT), application)
SRV = wsgiserver.CherryPyWSGIServer((HOST, PORT), application)
if service_conf.HTTPS:
SRV.ssl_adapter = ssl_pyopenssl.pyOpenSSLAdapter(SERVER_CERT,
SERVER_KEY, CERT_CHAIN)
logger.info("Server starting")
print "SP listening on port: %s" % PORT
print "SP listening on %s:%s" % (HOST, PORT)
try:
SRV.start()
except KeyboardInterrupt: