openstack/deb-python-pysaml2
Code Issues Proposed changes

refactoring xmlstr argument to enc_request (to remove defense against outside code reviewers ;-)

Browse Source
This commit is contained in:
rhoerbe
2014-10-19 16:00:42 +02:00
parent 816dcc7610
commit d62dcd5daa
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/saml2/entity.py
View File

@@ -588,10 +588,10 @@ class Entity(HTTPBase):
else: else:
return typ return typ
def _parse_request(self, xmlstr, request_cls, service, binding): def _parse_request(self, enc_request, request_cls, service, binding):
"""Parse a Request """Parse a Request
:param xmlstr: The request in its transport format :param enc_request: The request in its transport format
:param request_cls: The type of requests I expect :param request_cls: The type of requests I expect
:param service: :param service:
:param binding: Which binding that was used to transport the message :param binding: Which binding that was used to transport the message
@@ -625,8 +625,7 @@ class Entity(HTTPBase):
self.config.attribute_converters, self.config.attribute_converters,
timeslack=timeslack) timeslack=timeslack)
origdoc = xmlstr xmlstr = self.unravel(enc_request, binding, request_cls.msgtype)
xmlstr = self.unravel(xmlstr, binding, request_cls.msgtype)
must = self.config.getattr("want_authn_requests_signed", "idp") must = self.config.getattr("want_authn_requests_signed", "idp")
only_valid_cert = self.config.getattr( only_valid_cert = self.config.getattr(
"want_authn_requests_only_with_valid_cert", "idp") "want_authn_requests_only_with_valid_cert", "idp")
@@ -634,7 +633,7 @@ class Entity(HTTPBase):
only_valid_cert = False only_valid_cert = False
if only_valid_cert: if only_valid_cert:
must = True must = True
_request = _request.loads(xmlstr, binding, origdoc=origdoc, must=must, _request = _request.loads(xmlstr, binding, origdoc=enc_request, must=must,
only_valid_cert=only_valid_cert) only_valid_cert=only_valid_cert)
_log_debug("Loaded request") _log_debug("Loaded request")